Ignore generated CSS files for all multisite installations#2572
Conversation
- Changed formidableforms1.css to formidableforms[0-9]*.css to ignore all numbered versions - Pattern now matches any CSS file with formidableforms followed by digits - Maintains existing ignores for other build artifacts and language files
WalkthroughReplaced exact formidableforms CSS filename matches with a numeric-wildcard pattern ( Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@shervElmi My main concern with this is that it might not cover our zip files. If someone has this file locally, it might get included in a release. We'll need to also modify https://github.com/Strategy11/formidable-forms/blob/master/bin/zip-plugin.sh |
- Added pattern "*/formidableforms[0-9]*.css" to exclude versioned CSS files during zip creation - Prevents unnecessary files from being included in the production plugin package - Complements existing exclusion of formidableforms.css
|
|
@Crabcyborg could we merge this PR? Since I'm using multiple sites in my local environment, I always need to make sure automatically generated styles are not committed to the remote. Thanks so much! |
Ignore generated CSS files for all multisite installations
Updates the gitignore pattern to ignore CSS files generated for any multisite blog ID, not just blog 1.
Previously only
formidableforms1.csswas ignored. Now all numbered variants (formidableforms2.css, formidableforms17.css, etc.) are ignored.Related Code