Skip to content

Ignore generated CSS files for all multisite installations#2572

Merged
Crabcyborg merged 4 commits into
masterfrom
ignore-multisite-css-files
Dec 16, 2025
Merged

Ignore generated CSS files for all multisite installations#2572
Crabcyborg merged 4 commits into
masterfrom
ignore-multisite-css-files

Conversation

@shervElmi

Copy link
Copy Markdown
Contributor

Updates the gitignore pattern to ignore CSS files generated for any multisite blog ID, not just blog 1.

Previously only formidableforms1.css was ignored. Now all numbered variants (formidableforms2.css, formidableforms17.css, etc.) are ignored.

Related Code

image

- Changed formidableforms1.css to formidableforms[0-9]*.css to ignore all numbered versions
- Pattern now matches any CSS file with formidableforms followed by digits
- Maintains existing ignores for other build artifacts and language files
@shervElmi shervElmi self-assigned this Nov 3, 2025
@shervElmi
shervElmi marked this pull request as ready for review November 3, 2025 15:39
@shervElmi
shervElmi requested a review from Crabcyborg November 3, 2025 15:39
@coderabbitai

coderabbitai Bot commented Nov 3, 2025

Copy link
Copy Markdown
Contributor

Walkthrough

Replaced exact formidableforms CSS filename matches with a numeric-wildcard pattern (formidableforms[0-9]*.css) in both .gitignore and bin/zip-plugin.sh, broadening ignored and ZIP-excluded CSS file names.

Changes

Cohort / File(s) Summary
Ignore/zip pattern update
\.gitignore, bin/zip-plugin.sh
Replaced specific filename entries with the wildcard pattern formidableforms[0-9]*.css so any formidableforms CSS file suffixed with digits is ignored and excluded from ZIPs.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

  • Check shell escaping/zip exclude behavior in bin/zip-plugin.sh to confirm the pattern is applied as intended across environments.

Possibly related PRs

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: updating ignore patterns for generated CSS files across multisite installations.
Description check ✅ Passed The description is directly related to the changeset, explaining the motivation and specifics of the CSS file pattern changes across both .gitignore and the zip plugin script.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch ignore-multisite-css-files

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4a120b1 and 3ea892b.

📒 Files selected for processing (1)
  • bin/zip-plugin.sh (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: PHP 7.4 tests in WP trunk
  • GitHub Check: PHP 8 tests in WP trunk
  • GitHub Check: Cypress
🔇 Additional comments (1)
bin/zip-plugin.sh (1)

65-65: LGTM! Correctly excludes multisite CSS files from the release zip.

The exclusion pattern properly targets numbered CSS files generated by multisite installations, complementing the base formidableforms.css exclusion on line 64. This ensures auto-generated styles for different blog IDs won't be included in plugin releases.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Crabcyborg

Copy link
Copy Markdown
Contributor

@shervElmi My main concern with this is that it might not cover our zip files. If someone has this file locally, it might get included in a release.

We'll need to also modify https://github.com/Strategy11/formidable-forms/blob/master/bin/zip-plugin.sh

- Added pattern "*/formidableforms[0-9]*.css" to exclude versioned CSS files during zip creation
- Prevents unnecessary files from being included in the production plugin package
- Complements existing exclusion of formidableforms.css
@shervElmi

Copy link
Copy Markdown
Contributor Author

@shervElmi My main concern with this is that it might not cover our zip files. If someone has this file locally, it might get included in a release...

fix: exclude versioned CSS files from plugin zip

@shervElmi

Copy link
Copy Markdown
Contributor Author

@Crabcyborg could we merge this PR? Since I'm using multiple sites in my local environment, I always need to make sure automatically generated styles are not committed to the remote. Thanks so much!

@Crabcyborg Crabcyborg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @shervElmi!

Yeah, this seems to work great!

🚀

@Crabcyborg Crabcyborg modified the milestones: 6.27, 6.26.1 Dec 16, 2025
@Crabcyborg
Crabcyborg merged commit dca7bfe into master Dec 16, 2025
16 checks passed
@Crabcyborg
Crabcyborg deleted the ignore-multisite-css-files branch December 16, 2025 15:34
stephywells pushed a commit that referenced this pull request Apr 4, 2026
Ignore generated CSS files for all multisite installations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants