Sort numeric custom fields by value#517
Merged
Merged
Conversation
Cast validated numeric sortbar fields after whitespace removal so values like 6, 50, and 500 order correctly.
WalkthroughThe sortbar_orderby() function was modified to introduce a $numeric_sort flag that determines whether a meta-derived sort field should use a numeric-safe REPLACE/+0 expression instead of the existing get_space_replace() ordering logic. ChangesSortbar Orderby Numeric Handling
Estimated code review effort: 2 (Simple) | ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Route default and sortbar ordering through one numeric-aware helper so validated numeric fields sort correctly across directory queries.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes Strategy11/business-directory-premium#90
Validated numeric fields now sort by value across sortbar and default directory queries through shared numeric-aware orderby handling.