Skip to content

Show Terms of Service for admins on Place Ad#145

Merged
sorinmarta merged 3 commits into
masterfrom
fix/3131-tos-for-admins
Jul 20, 2026
Merged

Show Terms of Service for admins on Place Ad#145
sorinmarta merged 3 commits into
masterfrom
fix/3131-tos-for-admins

Conversation

@sorinmarta

@sorinmarta sorinmarta commented Jul 20, 2026

Copy link
Copy Markdown
Contributor

Fixes Strategy11/awpcp#3131
Remove the moderator bypass so Place Ad shows and requires Terms of Service for admins and moderators when the setting is enabled.

Moderator bypass hid ToS when requiredtos was enabled; remove it so all users must accept.
@coderabbitai

coderabbitai Bot commented Jul 20, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@sorinmarta, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 20 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 8892b308-e8e8-4551-9c85-b38ebaccf8f0

📥 Commits

Reviewing files that changed from the base of the PR and between 443b1ac and f632561.

📒 Files selected for processing (7)
  • frontend/page-place-ad.php
  • includes/class-container-configuration.php
  • includes/constructor-functions.php
  • includes/form-fields/class-form-fields-validator.php
  • includes/form-fields/class-terms-of-service-form-field.php
  • tests/suite/form-fields/test-form-fields-validator.php
  • tests/suite/form-fields/test-terms-of-service-form-field.php
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/3131-tos-for-admins

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@sorinmarta sorinmarta added run analysis Run the phpcs run tests Run the unit tests labels Jul 20, 2026
Align unit expectation with showing Terms of Service to moderators.
Drop dead DI after moderator ToS bypass removal to satisfy PHPStan.
@sorinmarta
sorinmarta merged commit 870642a into master Jul 20, 2026
5 checks passed
@sorinmarta
sorinmarta deleted the fix/3131-tos-for-admins branch July 20, 2026 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run analysis Run the phpcs run tests Run the unit tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant