Add brand favicon to the dashboard#14
Merged
Merged
Conversation
Cream serif R on a terracotta tile (#d2603f) matching the Relay wordmark, as an SVG so it scales crisply and embeds with the existing go:embed dist. Adds the icon link and a theme-color meta to index.html; Vite copies public/favicon.svg into dist/ where the server already serves real assets before the SPA fallback.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The dashboard had no favicon — browsers requested
/favicon.svgand fell through to the SPA. This adds a small on-brand SVG favicon: a cream (#ece3d4) serif R on a terracotta (#d2603f) rounded tile, matching the "Relay." wordmark.web/public/favicon.svg(scalable, ~366 B); Vite copies it intodist/on build.web/index.htmlgains<link rel="icon" type="image/svg+xml">and a<meta name="theme-color" content="#15120e">(dark espresso, for mobile browser chrome).web/embed.go) already serves realdist/files before the SPA fallback, so/favicon.svgis served directly.web/distrebuilt and committed (no asset-hash churn — onlyindex.htmlchanged plus the new favicon).Test Plan
npm run typecheckcleannpm run build—dist/favicon.svgemitted,dist/index.htmlreferences itnpm run test— 17/17 passgo test ./web/— embed handler test passes