SSE single-poller fan-out: bound Redis load to O(queues), not O(connections)#13
Merged
Conversation
Replaces per-connection Redis polling (O(connections x queues)/sec) with one in-process hub: a single background poller broadcasts snapshots to all subscribers, bounding Redis load to O(queues)/sec. Lazy lifecycle (polls only while >=1 dashboard connected), wire-format unchanged, no new deps.
Owner
Author
Code reviewNo issues found. Checked for bugs and CLAUDE.md compliance. 🤖 Generated with Claude Code - If this code review was useful, please react with 👍. Otherwise, react with 👎. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces the per-connection SSE polling on
GET /api/streamwith a single in-process fan-out hub, so dashboard streaming scales with queue count instead of connection count.SCANfor queue discovery +Stats/Countersper queue). Redis load was O(connections × queues)/sec, and every connection recomputed the identical global snapshot — the limiter well before Go's HTTP layer.This implements the fan-out that CLAUDE.md previously flagged as future work.
Design
hub(internal/api/hub.go) owns all polling + broadcast, behind asnapshotSourceinterface (satisfied by*broker.Broker) so its fan-out/lifecycle is unit-tested without Redis.subscribe, stops on the lastunsubscribe.data: <json array>\n\n) — the committedweb/distdashboard is untouched; no frontend change, no dist rebuild.docs/superpowers/specs/2026-06-09-relay-sse-single-poller-fanout-design.md.Test Plan
go test -race ./...— all packages pass, including the real-RedisTestStreamEmitsSnapshot(runs through the hub, not skipped)go build ./...andgo vet ./internal/api/cleanweb/untouched; onlyCLAUDE.md+ 4internal/apifiles changed