Feature/UI improv#215
Open
dongwonyang wants to merge 8 commits into
Open
Conversation
… getResourceString하나로 통일
…가 발생할 수 있음. glide로 변경)
…eature/uiImprov
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
storageDao.deleteImage 함수 삭제가 제대로 안되는 것 같습니다. 그래서 포스트 필드값을 "images_url" to emptyList()로 추가해두었습니다. 수요일 오전에 왜 삭제가 안되는 지 확인해보겠습니다.
프로필 이미지 재사용 문제는 coil 사용시만 문제가 발생해서 메모리 캐싱문제인가 해서 memoryCachePolicy(CachePolicy.DiSABLE)를 추가해봤는데도 문제가 해결이 안되서 랭킹, 커뮤니티 어뎁터에서 glide로 변경했습니다.