Skip to content

Updates Lottery tests to avoid false positives #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AndrewGardhouse wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Updates Lottery tests to avoid false positives #4

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
53e9a62
Lottery tests that use try/catch no longer return false positives
May 2, 2018
78e6ecf
Adds lottery entrant to pickWinner() test to avoid false positive
May 2, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions lottery/test/Lottery.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,21 +65,26 @@ describe('Lottery Contract', () => {
from: accounts[0],
value: 0
});
assert(false);
} catch (err) {
assert(err);
return assert(err);
}
assert(false);
});

it('only manager can call pickWinner', async () => {
await lottery.methods.enter().send({
from: accounts[1],
value: web3.utils.toWei('0.02', 'ether')
});

try {
await lottery.methods.pickWinner().send({
from: accounts[1]
});
assert(false);
} catch (err) {
assert(err);
return assert(err);
}
assert(false);
});

it('sends money to the winner and resets the players array', async () => {
Expand Down