fix: resolve CI lint error and add CI workflow with status badge#41
Open
teeschima wants to merge 1 commit into
Open
fix: resolve CI lint error and add CI workflow with status badge#41teeschima wants to merge 1 commit into
teeschima wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes the CI pipeline by resolving a lint error in Navbar.tsx and adding a GitHub Actions CI workflow with a status badge to README.md.
Changes
Navbar.tsx lint fix
useEffectthat calledsetMobileOpen(false)onpathnamechange, which violated thereact-hooks/set-state-in-effectruleonClick={() => setMobileOpen(false)}directly to each mobile navLinkelement insteadCI workflow
.github/workflows/ci.ymlfile already existed with the correct configuration: runs on every PR to main, checks out code, sets up Node 20, installs deps, lints, and buildsStatus badge
Verification
npm run lint— passes (0 errors)npm run build— passes (exit 0)Closes #17