Add dataset validation results panel to demo admin dashboard#313
Merged
kryputh merged 1 commit intoJun 17, 2026
Merged
Conversation
1a6ac5c to
5a98598
Compare
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #220
Summary
Adds a
ValidationResultsPanelto the demo admin dashboard that surfaces dataset validation errors and warnings, each with its field path, so demo data issues are easy to scan and fix.All work is contained within
src/features/demo-admin-dashboard/. No files outside that folder are touched.What's included
ValidationResultsPanel.tsx— groups issues by severity (errors → warnings → info), shows per-severity counts, field paths, and optional fix hints, with a clean empty state when there are no issues.validation-types.ts—ValidationIssue,ValidationSeverity, andValidationNavigation(datasetId / recordId / fieldPath) for jumping to a source field.validation.ts—summarizeValidation,sortIssues,groupBySeverity,getIssueNavigation,isDatasetValid.validationFixtures.ts— deterministic, fake sample issues (no real data, secrets, or network calls).ValidationResultsPanel.md.validation.test.ts— covers counts, sorting, grouping, navigation metadata, and validity checks.Navigation metadata
Passing
onSelectIssuemakes each issue clickable and reports{ datasetId, recordId, fieldPath }so a parent view can navigate to the offending field.Testing
npx vitest run src/features/demo-admin-dashboard/validation.test.ts— all passing