Fix PlaceAbove z-order positioning#3
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes Win32WindowZOrder.PlaceAbove so that the moved window ends up immediately above the relative target window (instead of being positioned behind it), and adds a Windows integration regression test to lock the behavior in.
Changes:
- Update
Win32WindowZOrder.PlaceAboveto compute the correcthWndInsertAfterusingGW_HWNDPREV. - Add a Windows integration regression test validating adjacency in the z-order chain.
- Introduce
NativeMethods.HwndTopto representHWND_TOPforSetWindowPos.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| tests/ModernOverlay.Tests/Win32StyleTests.cs | Adds a Windows integration regression test asserting PlaceAbove positions the overlay immediately above the target. |
| src/ModernOverlay.Win32/Win32WindowZOrder.cs | Fixes PlaceAbove by using the target’s previous window (via GetWindow(..., GW_HWNDPREV)) as the insertion point. |
| src/ModernOverlay.Win32/NativeMethods.cs | Adds HwndTop constant for use with SetWindowPos insertion semantics. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes Win32WindowZOrder.PlaceAbove so the positioned window is placed immediately above the relative target instead of behind it. Adds a Windows integration regression test. Validation: dotnet test tests\ModernOverlay.Tests\ModernOverlay.Tests.csproj --configuration Debug --filter PlaceAbovePositionsWindowImmediatelyAboveRelativeWindow.