Feat add fedora support#168
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds Linux distro-family detection so SteamCMD dependency installation can use Debian/Ubuntu or Fedora/RHEL-compatible package tooling, addressing non-Debian support from issue #166. It also updates the devcontainer setup.
Changes:
- Adds
/etc/os-releaseparsing and distro-family detection. - Splits SteamCMD dependency installation into Debian
apt-getand RHEL/Fedoradnfpaths. - Updates devcontainer Node/npm setup and adds a devcontainer feature lockfile.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/steamcmd/steamcmd-helper.go |
Adds distro detection and RHEL/Fedora dependency installation support. |
.devcontainer/Dockerfile |
Removes global npm upgrade during image build. |
.devcontainer/devcontainer.json |
Updates recommended extensions and post-create setup command. |
.devcontainer/devcontainer-lock.json |
Adds a lockfile for the Go devcontainer feature. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
JacksonTheMaster
left a comment
JacksonTheMaster
left a comment
There was a problem hiding this comment.
Code changes LGTM
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #166