Skip to content

feat: continue on linkfilter page if enhancement-no-linkfilter enabled#225

Merged
xPaw merged 5 commits into
SteamDatabase:masterfrom
nolddor:patch-1
Jun 28, 2025
Merged

feat: continue on linkfilter page if enhancement-no-linkfilter enabled#225
xPaw merged 5 commits into
SteamDatabase:masterfrom
nolddor:patch-1

Conversation

@nolddor

@nolddor nolddor commented Jun 27, 2025

Copy link
Copy Markdown
Contributor

Hi @xPaw today I noticed enhancement-no-linkfilter was not working well at my end on my profile links when those were manually introduced by myself long ago.

I am not aware of Steam being doing this but is a well-known trick among profile designer that using either:
1.- https://steamcommunity.com:/linkfilter/?url=
2.- https://steamcommunity.com:443/linkfilter/?url=

Allows you to hide the domain rendering. Since those are valid URLs and works as intended, I think we must catch those as well. Hence my PR.

With https://steamcommunity.com:/linkfilter/?url= -or- https://steamcommunity.com:443/linkfilter/?url=
image

With https://steamcommunity.com/linkfilter/?url=
image

That's why people use it when introducing the filter themselves at their profiles.

BR

EDIT:
Scope of this PR has changed, and now my proposal is to auto-continue if for any reason we land on linkfilter page.
See PR comments for further details.

@xPaw

xPaw commented Jun 27, 2025

Copy link
Copy Markdown
Member

wtf. this seems like an issue that needs to be reported to valve

@nolddor

nolddor commented Jun 27, 2025

Copy link
Copy Markdown
Contributor Author

Any official site to report such bugs? is https://hackerone.com the right place for this, any idea?

@xPaw

xPaw commented Jun 27, 2025

Copy link
Copy Markdown
Member

Yeah.

@nolddor

nolddor commented Jun 27, 2025

Copy link
Copy Markdown
Contributor Author

Problem was reported there. Let's see what they say about.

Anyway, even if they fix the rendering issue I believe there is nothing preventing people to use such value as a valid linkfilter URL so not sure how to do feel about merging it in the base code.

@nolddor

nolddor commented Jun 28, 2025

Copy link
Copy Markdown
Contributor Author

Had some more time to check into this today, seems like even with the feature enabled. If you paste a link into the Steam Chat you will land on the linkfilter page. Same for external links or indexed links by google, duckduckgo and similar...

I believe make sense to auto-continue if for some reason we land on linkfilter page. This will solve also my initial problem of using a non-standard linkfilter href.

Let me know if this makes more sense to you or not.
Cheers

@nolddor nolddor changed the title fix: enhancement-no-linkfilter does not check port feat: continue on linkfilter page if enhancement-no-linkfilter enabled Jun 28, 2025
Comment thread scripts/community/linkfilter_injected.js Outdated
@xPaw xPaw merged commit c5de3d7 into SteamDatabase:master Jun 28, 2025
1 check passed
@nolddor nolddor deleted the patch-1 branch August 15, 2025 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants