feat: continue on linkfilter page if enhancement-no-linkfilter enabled#225
Conversation
|
wtf. this seems like an issue that needs to be reported to valve |
|
Any official site to report such bugs? is https://hackerone.com the right place for this, any idea? |
|
Yeah. |
|
Problem was reported there. Let's see what they say about. Anyway, even if they fix the rendering issue I believe there is nothing preventing people to use such value as a valid linkfilter URL so not sure how to do feel about merging it in the base code. |
|
Had some more time to check into this today, seems like even with the feature enabled. If you paste a link into the Steam Chat you will land on the linkfilter page. Same for external links or indexed links by google, duckduckgo and similar... I believe make sense to auto-continue if for some reason we land on linkfilter page. This will solve also my initial problem of using a non-standard linkfilter href. Let me know if this makes more sense to you or not. |
Hi @xPaw today I noticed
enhancement-no-linkfilterwas not working well at my end on my profile links when those were manually introduced by myself long ago.I am not aware of Steam being doing this but is a well-known trick among profile designer that using either:
1.- https://steamcommunity.com:/linkfilter/?url=
2.- https://steamcommunity.com:443/linkfilter/?url=
Allows you to hide the domain rendering. Since those are valid URLs and works as intended, I think we must catch those as well. Hence my PR.
With

https://steamcommunity.com:/linkfilter/?url=-or-https://steamcommunity.com:443/linkfilter/?url=With

https://steamcommunity.com/linkfilter/?url=That's why people use it when introducing the filter themselves at their profiles.
BR
EDIT:
Scope of this PR has changed, and now my proposal is to auto-continue if for any reason we land on linkfilter page.
See PR comments for further details.