docs(start-os): name the installer's Preserve button in the password-reset guides - #3625
Open
stupleb wants to merge 1 commit into
Open
docs(start-os): name the installer's Preserve button in the password-reset guides#3625stupleb wants to merge 1 commit into
stupleb wants to merge 1 commit into
Conversation
…reset guides Both password-reset guides told the user to select "Keep my data" when choosing a drive. No such label exists: the setup wizard's StartOS Data Detected dialog offers Preserve / Overwrite (web/setup-wizard/src/app/components/preserve-overwrite.dialog.ts). These are the pages a locked-out user lands on, so the wrong button name hits at the worst possible moment. Name Preserve, matching installing-startos.md and update-040.md. That dialog also opens once the data drive has been chosen rather than during selection, so the step no longer folds the two screens into one. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both password-reset guides told the user to select Keep my data when choosing a drive. That label does not exist in StartOS.
The drift
The setup wizard's StartOS Data Detected dialog offers Preserve / Overwrite — see
projects/start-os/web/setup-wizard/src/app/components/preserve-overwrite.dialog.ts(Preserveat L49 and L86,Overwriteat L53 and L75, the dialog heading at L35). "Keep my data" appears nowhere in the repo.This matters more than a typical wording slip:
reset-password.mdandforgot-password.mdare the two pages a locked-out user lands on. A wrong button name hits at the worst possible moment, on a screen where the other button erases their data.The fix
Both pages now name Preserve, matching the pages that already had it right —
installing-startos.md(Install section) andupdate-040.md(Step 7, Flash Update tab).The step is also reworded from "When selecting your data drive, select …" to "When prompted, select …": the dialog opens after the data drive has been chosen, not during selection, so the old phrasing folded two screens into one.
Notes
CHANGELOG.mdentry, per the rootAGENTS.mdrule (which is conditioned on changes that alter user-visible behavior). Independently:start-os/v0.4.0.1is a cut tag on origin and the changelog's top heading is## [0.4.0.1], so that line is fully released — an entry would require cutting a new heading and bumping the manifest, which a docs correction does not warrant.to keep your datahits are the real product strings in the dialog anddrives.page.ts.Verification
mdbook buildon the StartOS book — clean.prettier --checkon both pages — clean.