Review pass: SDK conformity, credential + relay UX, docs, i18n#2
Merged
Conversation
Audit and update of the community-contributed keep-startos against start-docs/packaging and the start9-registry packages. Conformity: - Rename the version file to current.ts (export `current`); keep version 0.4.0:0. - Add AGENTS.md, CLAUDE.md, TODO.md; sync s9pk.mk, .gitignore, .dockerignore, CONTRIBUTING.md to the registry canon. - Add tagAndRelease.yml; enable FREE_DISK_SPACE in release.yml (source build). - Renumber the i18n dictionary to close a stale index gap. Credentials (recipe-admin-credentials): - Drop the generate-in-init + "Show Login Credentials" reveal anti-pattern. A setupOnInit watcher now raises a critical task pointing at one Set Web Admin Password action that generates, stores, and returns the token (first-set and rotation). The vault password stays an internal secret. Remove credentials.ts and actions/showLoginCredentials.ts. Relays: - Seed upstream keep-core's canonical default relay set instead of a single relay. keep-web's bunker crashes with zero relays, so require >=1 (max 10, 256-char URLs), tighten the wss:// pattern, and fall back to the default set in main.ts. Docs: - Rewrite README.md and instructions.md to the writing-readmes / writing-instructions conventions; sync UPDATING.md. i18n: - Translate all dictionary strings and the release notes into es_ES, de_DE, pl_PL, fr_FR. Verified on a dev StartOS box: builds, installs, runs healthy; the credential task, password set/rotate, and Configure form work; i18n resolves per locale. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
MattDHill
approved these changes
Jun 20, 2026
Author
|
Thanks for the review and merge, @MattDHill! 🎉 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Audit and update of the community-contributed keep-startos (Keep — an always-on FROST threshold co-signer) against
start-docs/packagingand thestart9-registrypackages, ahead of Community Registry listing.Rebased onto
main@ keep 0.4.8 (PR #1 landed while this was in flight). Package version is now 0.4.8:0, and the relay default is reconciled to upstream's coracle choice (see Relays).Verified end-to-end on a dev StartOS box (keep-web 0.4.8 built from source): installs, runs healthy; the credential task, password set/rotate, Configure form, and coracle relay default all work; i18n resolves per locale.
Conformity
current.tsat0.4.8:0withother: [], per the "latest lives incurrent.ts" rule. Intermediate release notes remain in git history;current.tsuses an "initial StartOS listing" note — happy to swap in the 0.4.8 changelog if preferred.AGENTS.md,CLAUDE.md,TODO.md; synceds9pk.mk,.gitignore,.dockerignore,CONTRIBUTING.mdto canon.tagAndRelease.yml; enabledFREE_DISK_SPACEinrelease.yml.Credentials — fix an anti-pattern
Replaced the generate-in-init + Show Login Credentials reveal pattern with
recipe-admin-credentials: asetupOnInitwatcher raises a critical task only while the token is unset, pointing at one Set Web Admin Password action (generate → store → return; first-set and rotation). The vault password stays an internal secret. Removedcredentials.tsandactions/showLoginCredentials.ts.Relays — reconciled with upstream 0.4.8
keep-web's bunker hard-requires ≥1 relay (
require_relay_urls→ crashes the co-signer on empty). My branch originally seeded keep-core 0.4.0's 4-relay set — but keep 0.4.8 changeddefault_frost_relaysto a singlewss://bucket.coracle.social, because general-purpose relays (nos.lol, damus, …) drop the rapid ephemeral kind-24242 events FROST needs, stalling signing rounds. I reconciled to coracle (the 4-set would have been a regression) and kept the hardening: require ≥1 relay (the form previously allowed empty → a deferred crash once a share is imported), cap at 10 / 256-char URLs, tighten thewss://pattern, and fall back to the default inmain.ts. Adding relays for redundancy is the Configure action's job (upstream's own guidance).Multi-group (0.4.6)
Folded the new active-group / no-crash semantics into
instructions.mdandREADME.md:KEEP_FROST_GROUPis an optional pin; with shares for multiple groups the co-signer auto-selects one and you switch the active group in the Web Admin's Shares section.Docs & i18n
README.mdandinstructions.mdto thewriting-readmes/writing-instructionsconventions; syncedUPDATING.md.Notes for review
packageRepoleft asprivkeyio/keep-startos(author's repo) — matches the README/CONTRIBUTING clone URLs and thestash-startosprecedent. Easy to switch toStart9-Community/keep-startosif that's the policy.otherentries.🤖 Generated with Claude Code