Skip to content

fix: join condition for invoices with multiple taxes and charges#25

Merged
dvdl16 merged 2 commits into
version-15from
fix/vat-multiple-charges-on-invoice
Jun 20, 2025
Merged

fix: join condition for invoices with multiple taxes and charges#25
dvdl16 merged 2 commits into
version-15from
fix/vat-multiple-charges-on-invoice

Conversation

@dvdl16

@dvdl16 dvdl16 commented Jun 20, 2025

Copy link
Copy Markdown
Collaborator

Description

  • fix: join condition for invoices with multiple taxes and charges

Type of change

  • 🟢 Bug fix (change which fixes an issue)
  • ⚪ New feature (change which adds functionality)
  • ⚪ Breaking change (fix or feature that would cause existing functionality to not work as expected)

Tests

  • Unit Tests have been updated or added, as required
  • UI Tests have been updated or added, as required

Checklist:

  • My code follows Naming Guidelines (DocType, Field and Variable naming)
  • No Form changes / My code follows the Form Design Guidelines
  • My code follows the Coding Standards of this project
  • My code follows the Code Security Guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas / No comments necessary
  • I have made corresponding additions/changes to the documentation
  • All business logic and validations are on the server-side / No business logic or validation changes
  • No patches are necessary / Migration Patches have been added to the correct subdirectory of /patches and patches.txt have been updated

User Experience:

N/A

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 40.38%. Comparing base (8ccf63f) to head (ee0a9b5).

Files with missing lines Patch % Lines
csf_za/__init__.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           version-15      #25   +/-   ##
===========================================
  Coverage       40.38%   40.38%           
===========================================
  Files              10       10           
  Lines             463      463           
===========================================
  Hits              187      187           
  Misses            276      276           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@dvdl16 dvdl16 merged commit 1ce59b9 into version-15 Jun 20, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants