[BugFix] Check the return value of posix_memalign before use the aligned buffer.#25
Open
GavinMar wants to merge 2 commits into
Open
[BugFix] Check the return value of posix_memalign before use the aligned buffer.#25GavinMar wants to merge 2 commits into
posix_memalign before use the aligned buffer.#25GavinMar wants to merge 2 commits into
Conversation
…ependent libraries from system default path first. Setting it to `OFF` can ensure find the dependent libraries from the given thirdparty path. Signed-off-by: GavinMar <yangguansuo@starrocks.com>
…igned buffer. Signed-off-by: GavinMar <yangguansuo@starrocks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR, we check the return value of
posix_memalignbefore use the aligned buffer. On the one hand, it can avoid the-Wunused-resultwarning in some compiles, on the other hand, it helps avoid some unexpected error caused by posix memory operarions.Also, we add the
mutexheader files to some source files in case of theundefined unique_lockfor some special build environment.