Trim crypto++ - #41
Open
alex-ozdemir wants to merge 6 commits into
Open
Conversation
|
Mind if I extend the branch for full AWSLinux2 support so gg can run from AWS Lambda? AWS Linux2 distro is still on protobuf2 and cmake 2. Probably out of scope but one user was complaining of nvcc compiler needing extra support, might just be a README tweak on which lines in the config to alter for other compilers. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Isolate our dependencies on
crypto++.First of all, this should (slightly) improve compile times.
Second, since the location of the
crypto++headers is platform-dependent, this includes will need to be macro-guarded, or something like that, so it makes sense to thin them out.