Skip to content

fix(utils-sound): muted SFX emit a full-volume click — apply player volume to the Howl default #31

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
auraladigital wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix(utils-sound): muted SFX emit a full-volume click — apply player volume to the Howl default #31

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions packages/utils-sound/src/createPlayer.svelte.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -82,8 +82,11 @@ function createPlayer<TSoundName extends string, TPlay extends Function>(playerO
const volume = (volume: number) => {
playerVolume = volume;

//Adjust the whole player volume
// howl.volume(playerVolume);
// Also set the Howl's default volume, so a sound played AFTER this runs
// inherits the current (e.g. muted) level. Otherwise it starts at the
// Howl default and emits a full-volume attack transient before
// initSoundVolume applies its per-sound volume — an audible click when muted.
playerOptions.howl.volume(playerVolume);

//adjust volume per sound
(Object.values(soundMap) as Sound[]).forEach((sound) => {
Expand Down