security: enable RLS on public tables + fix cross-program IDOR#182
Merged
Conversation
… status update 1) RLS: the Supabase Data API exposed every public table to the anon key (shipped in the client bundle) for read AND write — verified anon could SELECT/DELETE/UPDATE projects, program_admins, multisig_*. Enable RLS (deny-all) on all public tables; server uses service_role (BYPASSRLS) and the client only uses Supabase auth, so zero functional impact. Already applied to prod; committing so repo history matches. 2) IDOR: updateApplicationStatus updated by applicationId without verifying it belongs to the program in the slug, letting a program-A admin mutate program-B applications. Now fetch + assert programId match before any write. 429 server tests pass.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security fixes from an audit triggered by the Supabase "RLS Disabled in Public" advisor. One fix (RLS) is already applied to prod; this PR puts it in the repo and adds the IDOR fix.
1. RLS disabled on public tables (P0, exploited verified)
The Supabase Data API (PostgREST) exposed every
publictable to the anon key — which ships in the client bundle — for read and write. Verified against prod with the live anon key:GET /projectsreturned real rows,DELETE /projectsandPATCH /program_adminsreturned 204 (privilege present). That bypasses the Express server's entire auth layer.Fix: enable RLS (deny-by-default, no policies) on all public tables. Safe with zero functional impact here because the server uses the
SERVICE_ROLEkey (BYPASSRLS) and the client uses Supabase only for auth, never table queries. Verified post-fix: anon now gets[]; Express server unaffected.2. Cross-program IDOR in
updateApplicationStatus(HIGH)PATCH /programs/:slug/applications/:applicationIdupdated by id without checking the application belonged to:slug's program — a program-A admin could mutate program-B applications. Now fetches the application and assertsprogramIdmatch before any write (404 otherwise). Added IDOR + not-found tests.Verification
429 server tests pass (replaced 1 obsolete best-effort-lookup test with 2 scoping tests). Prod anon access re-probed → closed.
server/.envwas committed in history (670b2bc) and removed (c44a048) — it contained a live MongoDB Atlas URI (jasonholt2002@hackathon0…mongodb.net). The Supabase service-role key was NOT in it. Rotate that Atlas password / delete the DB user; optionally purge it from history (BFG/filter-repo). Tracked separately from this PR.