Phase 1 : Refactor: expose resolved generation function - #190
Open
luca-belli wants to merge 4 commits into
Open
Conversation
luca-belli
force-pushed
the
refactor/generate-runtime-entrypoint
branch
from
August 8, 2026 18:13
306fd0b to
79b8aa5
Compare
luca-belli
changed the title
luca-belli
changed the title
jgieringer
reviewed
Aug 13, 2026
|
|
||
|
|
||
| async def main( | ||
| *, |
jgieringer
approved these changes
Aug 13, 2026
jgieringer
left a comment
jgieringer
left a comment
Collaborator
There was a problem hiding this comment.
LGTM besides smol comment
| parser.add_argument( | ||
| "--rubric-manifest", | ||
| default=None, | ||
| default="data/SI/rubric_manifest.json", |
Collaborator
There was a problem hiding this comment.
I wonder if this should be a static var since other files use it too?
Collaborator
Author
There was a problem hiding this comment.
you mean a var declared on top of the file?
This was referenced Aug 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
generate.mainthe reusable generation function called by the unifiedCLI (see Phase1: Feat: add unified vera generate command #191)
generate.mainowns no CLI defaultsand receives resolved persona files and context-template paths
resolved-input application function in
generate_conversations/run.pygenerate.pyparser and pipeline caller to resolve theirmanifest inputs before calling
generate.mainWhy this is separate
This is behavior-preserving plumbing for #191. It adds no unified CLI surface.
The temporary public boundary is
generate.main; a later atomic migration willdelete root
generate.pyand move the necessary generation code into thepermanent top-level
generate/package.Review guide
generate.mainis keyword-only and has no parameter defaultsgenerate_conversations/run.pyis 144 linesvera_cliis not introduced until Phase1: Feat: add unified vera generate command #191Validation