#19 - Add basketball pass lines#22
Open
apradillap wants to merge 2 commits into
Open
Conversation
- Add Lines function with comet, transparent, and colormap effects - Support coordinate transformations and basketball-specific applications - Add comprehensive testing and documentation - Bump version to 1.1.0 - Add CHANGELOG.md for version tracking
Contributor
Author
|
Hi @sreekar-voleti @ojadeyemi! When you have a moment, could you review my PR? Thanks a lot! |
Contributor
|
I tested the logic, and it looks like it works just fine. |
Contributor
Author
|
Fingers crossed this PR gets approved soon by @sreekar-voleti!! I'd reaaly like to take it further and maybe write a paper for a sports conference., it would be great to give this work some extra visibility. Thanks Sreekar!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Released in v1.1.0 — Adds a new
Linesfunction to mplbasketball for drawing lines (#19) on basketball courts, adapted from mplsoccer’s LineCollection but tailored for basketball visualizations.Features Added
Key Features
Files Added/Modified
mplbasketball/lines.py- New Lines functionalitymplbasketball/__init__.py- Updated to include Linesexamples/plot_lines.py- Example demonstrating Lines usagetests/test_lines.py- Comprehensive test suiteREADME.md- Updated with Lines documentationExample Usage
Testing
Breaking Changes
None - this is a new feature addition that doesn't affect existing functionality.
Dependencies
Documentation