Port to Avalonia 11.0.1#37
Open
NOoBODDY wants to merge 6 commits into
Open
Conversation
- Removed interfaces IAvaloniaObject, IControl etc. - AvaloniaProperty.AddOwner<>() now returns StyledProperty. So that some DirectProperties changed to StyledProperties. - Popup: PlacementMode -> Placement?, removed StaysOpen property - ItemsPresenter now don't have ItemsProperty and ItemsTemplateProperty. They are given from ItemControl parent. (HACK: Ribbon now has subscription of TabsProperty to ItemsProperty) - ItemsControl now have ItemsSource, which is used to set - Classes property in Control now is readonly. Changed to Classes.Add(_) - Some little changes
-Stays open was changed to "IsLightDismissEnabled". -"IsLightDismissEnabled" needs VisualLayerManager
|
@Splitwirez is there any plan to merge or is there any other work needing to be done? |
Owner
|
@rainyskye Closer to when this PR was first opened, I spoke with @NOoBODDY on Discord about a few changes which would need to be made, but...it doesn't look like they've pushed anything since then. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'd be glad if you could point out any faults. :)