Skip to content

Connectomes#4

Closed
russelljjarvis wants to merge 26 commits into
SpikingNetwork:masterfrom
russelljjarvis:connectomes
Closed

Connectomes#4
russelljjarvis wants to merge 26 commits into
SpikingNetwork:masterfrom
russelljjarvis:connectomes

Conversation

@russelljjarvis

Copy link
Copy Markdown

Another draft PR.

This code shows how Plugin matrix capabilities almost work.

@russelljjarvis russelljjarvis marked this pull request as ready for review February 17, 2023 05:44
@bjarthur bjarthur force-pushed the master branch 2 times, most recently from ebd735c to 8441f5c Compare February 17, 2023 13:54
@bjarthur

Copy link
Copy Markdown
Collaborator

the only code that needs to be in this PR is that in src/contrib/genPotjansConnectivity.jl. and that should be split into two files, one with the definition of genStaticWeights and the other with genPlasticWeights. the rest is just your test harness and shouldn't be committed.

@russelljjarvis

russelljjarvis commented Feb 22, 2023

Copy link
Copy Markdown
Author

AOK, that makes sense, I will revise and update.

It was tempting to try to put both the genStaticWeights and genPlasticWeights in the same file for computational tractability reasons, as they both could be made in the one pass of doubly nested for loop, and lumping them together would reduce the run time complexity of the code.

From a different perspective as of this moment I am not sure if the Potjan's model has plastic weights, and I think the default genPlasticWeights erdos method would be just as appropriate, as an approach that just finds idle static synapses.

@russelljjarvis

Copy link
Copy Markdown
Author

I still remember this PR. I am currently pre-occupied with lab work, but I am also incentivized by my lab to make this PR suitable.

@russelljjarvis

Copy link
Copy Markdown
Author

Okay. I have done rebasing and boiled this down to six commits.

I have also synced back up with your branch.

@russelljjarvis

Copy link
Copy Markdown
Author

Abandoned in favor of new less commits alternative.
#7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants