chore: remove release-please self-management from org-defaults repo#37
Merged
Conversation
The DEV-225 smoke test served its purpose — proved the Rosemary Releaser App auth chain works end-to-end (release PR authored by the App, tag push fires downstream workflows under the App identity). Going forward we don't want auto-releases on this repo: - It's not a versioned product. Consumers pin @v1 rolling, not specific point releases like @v1.0.3 vs @v1.0.4. - Every PR merge would open a release PR, doubling the merge ritual for what's effectively config maintenance. - Dog-fooding release-please is better served by an actual product repo when SpiceLabs ships one. Org-defaults is an unusual first test bed. Removed: - .github/workflows/release-please-self.yml (caller) - .github/workflows/release-cascade-check.yml (smoke-test only, "safe to delete once cascade verified" per its own header) - release-please-config.json, .release-please-manifest.json, version.txt, CHANGELOG.md (all release-please-self artifacts) Kept: - .github/workflows/release-please.yml — REUSABLE workflow for other repos to call. This was DEV-222's deliverable. - .github/workflows/release-artifacts.yml — REUSABLE workflow for SBOM/SLSA/cosign on consumer-repo tag pushes. DEV-223's deliverable. - v1.0.0 tag + GitHub Release — historical record of the smoke test. - Rolling v1 tag at its current position (advanced manually after smoke test). Refs: DEV-225 (closes once merged)
![pepper-pr-review[bot]](https://avatars.githubusercontent.com/in/3638927?s=60&v=4){kind=small}
There was a problem hiding this comment.
Verified against DEV-225 (Linear) — aligned. This PR removes the smoke-test machinery added in PR #35 after successful end-to-end verification of the Rosemary Releaser App auth chain. The six deleted files (five from PR #35 plus the generated CHANGELOG) are legitimate cleanup; the reusable workflows for DEV-222 and DEV-223 remain intact. No test coverage needed for infrastructure removal.
When you're ready for another review pass, just drop a note with @pepper review and I'll take a look!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove the release-please-self machinery added in PR #35 (the DEV-225 smoke test) now that the smoke test has served its purpose.
Why
This repo isn't a versioned product. Consumers pin
@v1rolling, not specific point releases. Every PR merge would open a chore release PR — noise without consumer value. Dog-fooding release-please is better served by an actual product repo when SpiceLabs ships one.The smoke test proved the Rosemary Releaser App auth chain works end-to-end (release PR authored by
rosemary-releaser[bot], tag-push cascade fires under the App identity). Mission accomplished.Removed
.github/workflows/release-please-self.yml.github/workflows/release-cascade-check.ymlrelease-please-config.json.release-please-manifest.jsonversion.txtCHANGELOG.mdKept
.github/workflows/release-please.yml.github/workflows/release-artifacts.ymlv1.0.0tag + GitHub Releasev1tagv1.0.0's commit).Test plan
release-please-self.ymldoes NOT fire on the merge commit (it's deleted; nothing to fire)Refs: DEV-225 (closes once merged)