Skip to content

remove if TYPE_CHECKING#1672

Merged
Christian-B merged 5 commits into
masterfrom
remove_if-TYPE_CHECKING
May 21, 2026
Merged

remove if TYPE_CHECKING#1672
Christian-B merged 5 commits into
masterfrom
remove_if-TYPE_CHECKING

Conversation

@Christian-B

Copy link
Copy Markdown
Member

fixes #1412

The code as it was is marginally faster but

  • code is slightly harder to read
  • mypy is not checking the line of code being run

@Christian-B Christian-B requested a review from rowleya May 18, 2026 11:47
@Christian-B Christian-B merged commit a2ad9d6 into master May 21, 2026
15 checks passed
@Christian-B Christian-B deleted the remove_if-TYPE_CHECKING branch May 21, 2026 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

DelayExstensionVertex typing weirdness

3 participants