VOR related models and provenance#927
Open
andrewgait wants to merge 59 commits into
Open
Conversation
Conflicts: spinn_front_end_common/interface/interface_functions/placements_provenance_gatherer.py
Conflicts: spinn_front_end_common/interface/interface_functions/placements_provenance_gatherer.py
- may be best to move custom "SpiNNCer" provenance dataframe etc. outside of the current toolchain for now, and read from prov database
Conflicts: spinn_front_end_common/interface/provenance/db.sql spinn_front_end_common/interface/provenance/provenance_writer.py unittests/interface/provenance/test_provenance_database.py
andrewgait
added
the
incomplete_left_for_further_release
Conflicts: spinn_front_end_common/interface/provenance/db.sql spinn_front_end_common/interface/provenance/provenance_writer.py unittests/interface/provenance/test_provenance_database.py
rowleya
approved these changes
Aug 3, 2023
rowleya
left a comment
rowleya
left a comment
Member
There was a problem hiding this comment.
This looks fine. Note that the lut data is kind-of sPyNNaker specific, but at the same time not so much that it doesn't fit in here...
Update test as well
dkfellows
added
reporting/provenance
and removed
incomplete_left_for_further_release
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extra provenance information relating to the VOR PR in SpiNNakerManchester/sPyNNaker#1152