Skip to content

remove unused extra_allocations param #1363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Christian-B wants to merge 4 commits into
base: master
Choose a base branch
from
Open

remove unused extra_allocations param #1363

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e63daa5
remove unused extra_allocations param
Christian-B May 5, 2026
9bb27ba
remove unused imports
Christian-B May 5, 2026
1b8b2e0
Merge branch 'master' into there_are_no_extra_allocations
Christian-B May 19, 2026
ce0cc52
Merge branch 'master' into there_are_no_extra_allocations
Christian-B Jun 30, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion spinn_front_end_common/interface/abstract_spinnaker_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1058,7 +1058,7 @@ def _report_router_info(self) -> None:
with FecTimer("Router info report", TimerWork.REPORT) as timer:
if timer.skip_if_cfg_false("Reports", "write_router_info_report"):
return
routing_info_report([])
routing_info_report()

@final
def _execute_basic_routing_table_generator(self) -> None:
Expand Down
9 changes: 2 additions & 7 deletions spinn_front_end_common/utilities/report_functions/reports.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@
import logging
import os
import time
from typing import Iterable, Optional, TextIO, Tuple
from typing import Optional, TextIO

from spinn_utilities.config_holder import get_report_path
from spinn_utilities.ordered_set import OrderedSet
Expand Down Expand Up @@ -466,14 +466,10 @@ def _sdram_usage_report_per_chip_with_timesteps(
pass


def routing_info_report(extra_allocations: Iterable[
Tuple[ApplicationVertex, str]] = ()) -> None:
def routing_info_report() -> None:
"""
Generates a report which says which keys is being allocated to each
vertex.

:param extra_allocations:
Extra vertex/partition ID pairs to report on.
"""
file_name = get_report_path("path_router_info_report")
routing_infos = FecDataView.get_routing_infos()
Expand All @@ -482,7 +478,6 @@ def routing_info_report(extra_allocations: Iterable[
vertex_partitions = OrderedSet(
(p.pre_vertex, p.identifier)
for p in get_app_partitions())
vertex_partitions.update(extra_allocations)
progress = ProgressBar(len(vertex_partitions),
"Generating Routing info report")
for pre_vert, part_id in progress.over(vertex_partitions):
Expand Down
Loading