Provide a Stem overload which does not allocate memory - #4
Open
alex-davidson wants to merge 5 commits into
Open
Conversation
added 5 commits
February 23, 2024 17:26
Expose these arrays as ReadOnlySpan to avoid possibility of mutation. Note that this does mean that we take a dependency on System.Memory as .NET Standard 2.0 does not include this type. It may be preferable to build the library as `net48` and `netstandard2.1` to avoid this.
Make test-only methods 'internal' to conceal implementation details.
Since we never lengthen the word, we can use the same stack-based buffer for the entire process and avoid any further allocations. We implement our own ToLowerInvariant on a character-by-character basis because .NET's own implementation (at least under .NET Framework) allocates strings internally.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This refactor eliminates heap allocations from the stemming process. By accepting an output buffer from the caller we even avoid allocating a string for the result. The existing Stem method is retained to reduce likely breakage in consuming code.
Notes:
System.Memory, since .NET Standard 2.0 does not include span types.