fix(AccountCard): sequence label/tooltip, subentry reserve indicator, aria-labelledby (#168)#240
Open
KayProject wants to merge 1 commit into
Open
Conversation
…tor, aria-labelledby - Add a 'Sequence Number' sublabel with a tooltip explaining the field is 'Used to prevent duplicate transactions' - Show the base reserve impact under subentryCount: 'Subentries: N (+N*0.5 XLM reserved)' - Wire the content region to the card heading via id='account-card-heading' and aria-labelledby for screen-reader association - Add vitest.config.ts wiring jsdom + the (previously orphaned) src/setupTests.ts so the component test suite actually runs Closes Sorokit#168
|
@KayProject Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves the three issues in
AccountCarddescribed in #168.Sequence Numbersublabel with a tooltip: "Used to prevent duplicate transactions".Subentries: N (+N*0.5 XLM reserved)below the count.<h3>carriesid="account-card-heading"and the content region carriesaria-labelledby="account-card-heading".Acceptance criteria
aria-labelledbypointing to the headingnpm run buildpassesTests
Added
AccountCard.test.tsxcases for the sublabel + tooltip, the XLM reserve string, and thearia-labelledbyassociation. Also addedvitest.config.tswiring jsdom + the previously-orphanedsrc/setupTests.ts, so the component suite runs.Closes #168