Skip to content

NetworkBanner/NetworkScreen fixes for #170#238

Merged
k-deejah merged 1 commit into
Sorokit:mainfrom
frankrichard99:docs/170-network-banner-fixes
Jun 30, 2026
Merged

NetworkBanner/NetworkScreen fixes for #170#238
k-deejah merged 1 commit into
Sorokit:mainfrom
frankrichard99:docs/170-network-banner-fixes

Conversation

@frankrichard99

Copy link
Copy Markdown
Contributor

Summary

Issue #170 reported three problems in NetworkBanner and NetworkScreen:

  1. The banner rendered redundantly on the Network screen itself
  2. InfoCell values (passphrase, RPC URL, Horizon URL) had no copy mechanism
  3. The banner had no transition animation on network switch

All three fixes were already implemented and merged to main in commits
cddfe68, 3b9b7c5, and d7064cd, but the change was never recorded in
CHANGELOG.md and the issue was left open without a closing reference.

This PR closes that gap by adding a ### Fixed entry under [Unreleased]
documenting the change, and closes the issue.

Changes

  • MODIFIED CHANGELOG.md
    • Added a ### Fixed subsection under ## [Unreleased] documenting:
      • NetworkBanner suppression on the Network screen
      • Copy-to-clipboard buttons on Passphrase / RPC URL / Horizon URL InfoCells
      • Smooth transition-all duration-300 fade on NetworkBanner network switch

Verification

  • Confirmed via git diff main -- src/components/NetworkBanner.tsx src/screens/NetworkScreen.tsx that all three fixes already exist on main:
    • NetworkBanner.tsx: if (active === "network") return null; and transition-all duration-300 on the root div
    • NetworkScreen.tsx: copyable prop wired to Passphrase, RPC URL, and Horizon URL InfoCells, using the same copy-icon pattern as AddressDisplay
  • npm run build passes
  • This is a documentation-only change; no source/test files were modified

Closes #170

@k-deejah k-deejah merged commit 9ff22cd into Sorokit:main Jun 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(NetworkBanner,NetworkScreen): banner redundant on Network screen, InfoCell values not copyable, no banner transition animation

2 participants