fix: button variant#224
Open
dumbdevss wants to merge 1 commit into
Open
Conversation
|
@dumbdevss Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
closes #181
Improves the
Buttoncomponent with three additions:icon slot while
childrenstay in place, so short labels (e.g. "Send") nolonger shift or disappear when
loadingis set.iconOnlyprop — renders a square button (equal height/width, nohorizontal padding) sized per
size(sm/md/lg), so icon-only buttonsget the same focus ring and hover states as the rest of the component instead
of relying on raw
<button>elements with ad-hoc classes. While loading, thespinner replaces the icon entirely.
requireConfirm+confirmLabelprops — opt-in two-click confirmationfor dangerous actions. The first click arms the button and swaps the label to
confirmLabel(default "Are you sure?"); the second click firesonClick.The prompt auto-resets on blur. Pairs naturally with
variant="destructive".All three props are optional and default to prior behavior, so existing usages
are unaffected.