feat(AddressDisplay): add onCopy callback, select-all on full address…#219
Open
devOgazi wants to merge 2 commits into
Open
feat(AddressDisplay): add onCopy callback, select-all on full address…#219devOgazi wants to merge 2 commits into
devOgazi wants to merge 2 commits into
Conversation
…, and size prop for density control
- Add onCopy?: () => void prop that fires after successful clipboard write
- Add className="select-all" to address span when showFull={true}
- Add size?: 'sm' | 'md' | 'lg' prop controlling font size and icon size
- Export AddressDisplay and AddressDisplayProps from barrel index.ts
- Add missing dependencies (tailwind-merge, hugeicons, test libs, jsdom)
- Add vitest config with jsdom environment and test setup cleanup
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Three issues affect
AddressDisplaywhen used in different contexts across the library.Changes
1.
onCopycallback —onCopy?: () => voidfires after a successful clipboard write. Embedding components likeAccountCardor a receive-funds modal can now react (e.g., show a toast notification).2.
select-allon full address — WhenshowFull={true}, the address span getsclassName="select-all"so a single click selects the entire 56-char address instead of requiring drag/triple-click.3.
sizeprop for density control —size?: "sm" | "md" | "lg"controls font size and icon size:text-[10px]text-[11px]text-[13px]4. Barrel export —
AddressDisplayandAddressDisplayPropsare now exported fromsrc/components/index.ts.Acceptance Criteria
onCopyfires after successful clipboard writeselect-allwhenshowFull={true}sizeprop changes font and icon size appropriatelysize="md"tsc --noEmitpassesCloses #187