Skip to content

fix: resolve Card component padding/alignment, restore emptied compon…#156

Open
midexol wants to merge 5 commits into
Sorokit:mainfrom
midexol:main
Open

fix: resolve Card component padding/alignment, restore emptied compon…#156
midexol wants to merge 5 commits into
Sorokit:mainfrom
midexol:main

Conversation

@midexol

@midexol midexol commented Jun 27, 2026

Copy link
Copy Markdown
Contributor

Description
Standardizes the Card component properties and ref-forwarding, restores core component implementations that were commit-erased, and fixes the library compilation and test runner configurations.

Related Issues
Closes #103

Type of Change
Bug fix (non-breaking change which fixes an issue)
New feature (non-breaking change which adds functionality)
Breaking change (fix or feature that would cause existing functionality to change)
Documentation update
Testing
Describe how you tested your changes:

Ran npm run build to verify library ESM, CJS, and typescript declaration files compile successfully.
Ran npm run type-check to verify zero compile-time TypeScript errors.
Ran npx vitest run to verify all 239 unit tests in the project pass successfully.

@drips-wave

drips-wave Bot commented Jun 27, 2026

Copy link
Copy Markdown

@midexol Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits.

You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀

Learn more about application limits

@midexol

midexol commented Jun 29, 2026

Copy link
Copy Markdown
Contributor Author

Pull Request Update: Sync & Issue #188 Resolution
closes #188
I have synchronized the branch with the latest changes from upstream/main (resolving conflicts) and resolved all requirements for Issue #188 (Sidebar fixes):

  1. Sync & Conflict Resolution:
    Dependency Resolution: Pinned @creit.tech/stellar-wallets-kit to the latest stable v1 release (^1.9.5). The new adapter code relies on v1 APIs (such as allowAllModules, WalletNetwork, and constructor instantiation) which are modified in v2.
    Adapter & Entry Point Fixes: Integrated the new wallet connection and client adapter logic from the upstream branch, and corrected the malformed import syntax in src/main.tsx.
  2. Sidebar Navigation Updates (Issue fix(Sidebar): nav section not persisted on reload, inconsistent icon strokeWidth, redundant re-render on active item tap #188):
    State Persistence: Active navigation section is now stored in localStorage under "sorokit-active-nav" and restored on mount to prevent page refreshes resetting the view back to the wallet screen.
    Icon Consistency: Standardized all navigation icons to a consistent strokeWidth={1.5} in both active and inactive states.
    Redundant Mobile Re-renders: Tapping the active nav item in the mobile drawer now closes the drawer immediately without invoking unnecessary re-renders.
    The codebase compiles cleanly, has full unit test coverage for the changes, and is ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(Card): CardHeader padding mismatch, CardFooter hardcodes flex items-center, no forwardRef on sub-components

1 participant