feat: add Stellar public key validation before Horizon calls#61
Open
Hovibby wants to merge 1 commit into
Open
Conversation
- Upgrade isValidPublicKey() in shared/utils.ts to use StrKey.isValidEd25519PublicKey() from @stellar/stellar-sdk for full format, length, and CRC-16 checksum validation - Add early-exit guard in getAccount() - invalid keys return ACCOUNT_FETCH_FAILED with a descriptive message before any Horizon request is made - getBalances() and getAssetBalances() inherit validation via getAccount() delegation - Add early-exit guard in streamAccount() - invalid key yields a single error result and ends the stream immediately instead of failing on every poll tick - Expand isValidPublicKey tests: 13 cases covering valid key, wrong prefix, too short/long, empty string, null, undefined, number, lowercase chars, invalid chars (0/1/8/9), corrupted checksum, whitespace, contract ID as public key - Fix placeholder G... test keys in account.test.ts to valid Stellar public keys
Collaborator
|
@Hovibby kindly resolve the conflict. nice work.. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #3
for full format, length, and CRC-16 checksum validation
ACCOUNT_FETCH_FAILED before any Horizon request is made
error result and ends the stream immediately