refactor: parse plugin service rows into typed shapes#834
Open
Abdulmumin1 wants to merge 1 commit into
Open
Conversation
- Parse plugin DB rows and JSON columns at the service boundary with Zod - Add unit coverage for typed plugin parsing and invalid settings payloads - Add Playwright coverage for plugin settings activity log rendering Refs SonicJs-Org#435 Generated with Claude Code Co-Authored-By: Claude <noreply@anthropic.com> Signed-off-by: Abdulmumin Yaqeen <abdulmuminyqn@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Scope: a focused
#435slice that replaces loose plugin-service row/JSON handling with parsed typed shapes at the DB boundary, then updates the plugin settings page consumer to use the new activity shape.Refs #435
Changes
PluginServicewith Zod instead of passing loose DB values through the service layerTesting
Unit Tests
Commands run:
npm run type-check --workspace=@sonicjs-cms/corenpm test --workspace=@sonicjs-cms/core -- plugin-service.test.tsE2E Tests
Commands run:
npx playwright test tests/e2e/63-plugin-settings-activity.spec.ts --config=tests/playwright.config.tsScreenshots/Videos
Checklist