Skip to content

PLUGINAPI-187 SubmitReview: Use Vault token#287

Merged
claire-villard-sonarsource merged 1 commit intomasterfrom
Pavel/SubmitReviewToken
Apr 28, 2026
Merged

PLUGINAPI-187 SubmitReview: Use Vault token#287
claire-villard-sonarsource merged 1 commit intomasterfrom
Pavel/SubmitReviewToken

Conversation

@pavel-mikula-sonarsource
Copy link
Copy Markdown
Contributor

With the latest automation changes, we need the Vault-based token now. It's the same token as the one in RequestReview.yml file. Please take care of merging this, I have 200+ repos to update.

@pavel-mikula-sonarsource pavel-mikula-sonarsource requested a review from a team as a code owner April 28, 2026 09:27
@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod Bot changed the title SubmitReview: Use Vault token PLUGINAPI-187 SubmitReview: Use Vault token Apr 28, 2026
@hashicorp-vault-sonar-prod
Copy link
Copy Markdown

hashicorp-vault-sonar-prod Bot commented Apr 28, 2026

PLUGINAPI-187

@sonar-review-alpha
Copy link
Copy Markdown

sonar-review-alpha Bot commented Apr 28, 2026

Summary

This PR migrates the GitHub token in the SubmitReview workflow from GitHub Secrets to Vault, aligning it with the same pattern already established in RequestReview.yml and other secrets in this workflow. The Vault secret retrieves a token from development/github/token/{REPO_OWNER_NAME_DASH}-jira and passes it to the SubmitReview action. The unused pull-requests: read permission is also removed.

What reviewers should know

Key change: Line 29 — the github-token parameter now pulls from the Vault output instead of GitHub Secrets.

New Vault retrieval: Line 23 — adds the GitHub token fetch from Vault alongside the existing JIRA credentials (already Vault-based).

Verify: Check that the Vault secret path development/github/token/{REPO_OWNER_NAME_DASH}-jira exists and matches what RequestReview.yml uses. The JIRA credentials lines are unchanged — they already use the Vault approach.


  • Generate Walkthrough
  • Generate Diagram

🗣️ Give feedback

Copy link
Copy Markdown

@sonar-review-alpha sonar-review-alpha Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

Clean and correct change. The final state of SubmitReview.yml now exactly mirrors RequestReview.yml — same Vault secret path, same fromJSON expression for the token, same minimal permissions block. Dropping pull-requests: read is appropriate because RequestReview.yml has never needed it, and the Vault-sourced token carries the necessary repository-level permissions.

🗣️ Give feedback

@sonarqube-next
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@claire-villard-sonarsource claire-villard-sonarsource merged commit 98b2cff into master Apr 28, 2026
9 checks passed
@claire-villard-sonarsource claire-villard-sonarsource deleted the Pavel/SubmitReviewToken branch April 28, 2026 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants