PLUGINAPI-187 SubmitReview: Use Vault token#287
PLUGINAPI-187 SubmitReview: Use Vault token#287claire-villard-sonarsource merged 1 commit intomasterfrom
Conversation
SummaryThis PR migrates the GitHub token in the SubmitReview workflow from GitHub Secrets to Vault, aligning it with the same pattern already established in RequestReview.yml and other secrets in this workflow. The Vault secret retrieves a token from What reviewers should knowKey change: Line 29 — the New Vault retrieval: Line 23 — adds the GitHub token fetch from Vault alongside the existing JIRA credentials (already Vault-based). Verify: Check that the Vault secret path
|
There was a problem hiding this comment.
LGTM! ✅
Clean and correct change. The final state of SubmitReview.yml now exactly mirrors RequestReview.yml — same Vault secret path, same fromJSON expression for the token, same minimal permissions block. Dropping pull-requests: read is appropriate because RequestReview.yml has never needed it, and the Vault-sourced token carries the necessary repository-level permissions.
|





With the latest automation changes, we need the Vault-based token now. It's the same token as the one in RequestReview.yml file. Please take care of merging this, I have 200+ repos to update.