Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ plugins {
id("com.jfrog.artifactory") version "5.2.5"
id("org.sonarqube") version "7.2.3.7755"
id("org.jetbrains.kotlin.jvm") apply false
id("com.diffplug.spotless") version "6.11.0"
id("com.diffplug.spotless") version "6.25.0"
`maven-publish`
signing
}
Expand Down
2 changes: 1 addition & 1 deletion gradle.properties
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@ group=org.sonarsource.kotlin
version=3.6-SNAPSHOT
description=Code Analyzer for Kotlin
projectTitle=Kotlin
kotlinVersion=2.3.20
kotlinVersion=2.4.20-neptune-246
org.gradle.jvmargs=-Xmx4096M
20 changes: 10 additions & 10 deletions kotlin-checks-test-sources/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -8,17 +8,17 @@ repositories {

dependencies {
implementation("org.jetbrains.kotlin:kotlin-stdlib")
implementation("org.jetbrains.kotlinx:kotlinx-coroutines-core:1.5.1")
implementation("org.jetbrains.kotlin:kotlin-reflect:2.3.20")
implementation("org.jetbrains.kotlin:kotlin-test:2.3.20")
implementation("org.jetbrains.kotlin:kotlin-test-junit5:2.3.20")
implementation("com.squareup.okhttp3:okhttp:4.9.0")
implementation("commons-net:commons-net:3.8.0")
implementation("org.springframework.security:spring-security-crypto:5.7.2")
implementation("org.springframework.security:spring-security-core:4.2.17.RELEASE")
implementation("commons-codec:commons-codec:1.13")
implementation("org.jetbrains.kotlinx:kotlinx-coroutines-core:1.10.2")
implementation("org.jetbrains.kotlin:kotlin-reflect:2.4.20-neptune-246")
implementation("org.jetbrains.kotlin:kotlin-test:2.4.20-neptune-246")
implementation("org.jetbrains.kotlin:kotlin-test-junit5:2.4.20-neptune-246")
Comment on lines +12 to +14
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These three Kotlin library versions are hardcoded literals while every other module reads them from the kotlinVersion project property (e.g. sonar-kotlin-api/build.gradle.kts uses val kotlinVersion: String by project.ext). Next time kotlinVersion is bumped in gradle.properties, these lines won't be updated automatically — causing a mismatch between the Kotlin compiler the rest of the build uses and the libraries this test-sources module compiles against.

Suggested change
implementation("org.jetbrains.kotlin:kotlin-reflect:2.4.20-neptune-246")
implementation("org.jetbrains.kotlin:kotlin-test:2.4.20-neptune-246")
implementation("org.jetbrains.kotlin:kotlin-test-junit5:2.4.20-neptune-246")
val kotlinVersion: String by project.ext
implementation("org.jetbrains.kotlin:kotlin-reflect:$kotlinVersion")
implementation("org.jetbrains.kotlin:kotlin-test:$kotlinVersion")
implementation("org.jetbrains.kotlin:kotlin-test-junit5:$kotlinVersion")
  • Mark as noise

implementation("com.squareup.okhttp3:okhttp:4.12.0")
implementation("commons-net:commons-net:3.13.0")
implementation("org.springframework.security:spring-security-crypto:5.8.16")
implementation("org.springframework.security:spring-security-core:4.2.20.RELEASE")
implementation("commons-codec:commons-codec:1.21.0")
implementation("com.google.guava:guava:30.1.1-jre")
implementation("org.apache.commons:commons-lang3:3.17.0")
implementation("org.apache.commons:commons-lang3:3.20.0")
implementation("commons-lang:commons-lang:2.6")
}

Expand Down
2 changes: 1 addition & 1 deletion sonar-kotlin-api/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ dependencies {
isTransitive = false
}
}
implementation("org.jetbrains.kotlinx:kotlinx-serialization-core:1.10.0")
implementation("org.jetbrains.kotlinx:kotlinx-serialization-core:1.11.0")
implementation("com.github.ben-manes.caffeine:caffeine:2.9.3")
compileOnly(libs.sonar.plugin.api)
compileOnly(libs.slf4j.api)
Expand Down
2 changes: 1 addition & 1 deletion sonar-kotlin-plugin/build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ ruleApi {

buildscript {
dependencies {
classpath("com.guardsquare:proguard-gradle:7.6.1")
classpath("com.guardsquare:proguard-gradle:7.9.1")
}
}

Expand Down
Loading