Skip to content

JAVASE-202 Unpin SonarSource GitHub actions#88

Open
rombirli wants to merge 1 commit intomasterfrom
rombirli/unpin-vault-action-wrapper
Open

JAVASE-202 Unpin SonarSource GitHub actions#88
rombirli wants to merge 1 commit intomasterfrom
rombirli/unpin-vault-action-wrapper

Conversation

@rombirli
Copy link
Copy Markdown
Contributor

@rombirli rombirli commented May 5, 2026

No description provided.

@hashicorp-vault-sonar-prod hashicorp-vault-sonar-prod Bot changed the title Unpin SonarSource GitHub actions JAVASE-202 Unpin SonarSource GitHub actions May 5, 2026
@hashicorp-vault-sonar-prod
Copy link
Copy Markdown
Contributor

hashicorp-vault-sonar-prod Bot commented May 5, 2026

JAVASE-202

@sonar-review-alpha
Copy link
Copy Markdown

sonar-review-alpha Bot commented May 5, 2026

Summary

This PR unpins the SonarSource/vault-action-wrapper GitHub Action in the dogfood workflow from a specific commit hash (2.4.2-1) to the v3 version tag. This means the workflow will now use the latest v3 release instead of staying on the pinned version, receiving updates and fixes automatically.

What reviewers should know

Scope: Single line change in .github/workflows/dogfood.yml — the get secrets step.

Key consideration: Moving from a pinned commit SHA to a floating version tag means the action's behavior may change unexpectedly when v3 gets new releases. If stability is preferred, the pinned approach is safer; if staying current with fixes is priority, this is the right approach.

Context: The vault-action-wrapper is used to retrieve secrets for the dogfood workflow, so review whether the team is comfortable with automatic updates to this security-sensitive component.


  • Generate Walkthrough
  • Generate Diagram

🗣️ Give feedback

Copy link
Copy Markdown

@sonar-review-alpha sonar-review-alpha Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

Clean, correct alignment change. Every other workflow in the repository (build.yml, RequestReview.yml, PullRequestClosed.yml, PullRequestCreated.yml, ToggleLockBranch.yml, SubmitReview.yml, releasability.yaml) already uses SonarSource/vault-action-wrapper@v3. This PR brings dogfood.yml into line with the rest of the codebase — it was the only remaining workflow still on the old pinned commit SHA.

🗣️ Give feedback

@sonarqube-next
Copy link
Copy Markdown

sonarqube-next Bot commented May 5, 2026

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants