Skip to content

JAVASE-197 Fix discrepancies between MQR and severity for Java SE rules#83

Merged
dorian-burihabwa-sonarsource merged 1 commit intobranch-8.16from
db/JAVASE-197
Apr 13, 2026
Merged

JAVASE-197 Fix discrepancies between MQR and severity for Java SE rules#83
dorian-burihabwa-sonarsource merged 1 commit intobranch-8.16from
db/JAVASE-197

Conversation

@dorian-burihabwa-sonarsource
Copy link
Copy Markdown
Contributor

Ensures that rule severity is consistent in legacy and MQR modes.

@hashicorp-vault-sonar-prod
Copy link
Copy Markdown
Contributor

hashicorp-vault-sonar-prod Bot commented Apr 10, 2026

JAVASE-197

@dorian-burihabwa-sonarsource dorian-burihabwa-sonarsource marked this pull request as ready for review April 13, 2026 09:18
@sonar-review-alpha
Copy link
Copy Markdown

sonar-review-alpha Bot commented Apr 13, 2026

Summary

Upgrades the severity level of 6 Java SE rules from HIGH to BLOCKER impact to align with MQR mode definitions:

  • Reliability rules: S2095 (resource leak), S2689 (array/collection modification), S3546 (missing equality)
  • Security rules: S2755 (XML parsing vulnerabilities), S6373 (insecure deserialization)
  • Maintainability: S3516 (inappropriate regex expression)

These changes make the legacy experience rule severities consistent with MQR, ensuring users see the same rule priorities regardless of which analysis mode they use.

What reviewers should know

Scope: Metadata-only changes — no code logic modified, just rule definition JSON files in resources/org/sonar/l10n/java/rules/javase/.

What reviewers should check:

  • Verify that each rule listed above indeed warrants BLOCKER-level severity in MQR (you may need to cross-check with the MQR rule definitions or JAVASE-197 ticket)
  • Confirm these 6 rules are the complete set needing alignment — no rules were missed

Non-obvious details:

  • The impacts field in SonarQube's JSON schema uses BLOCKER/HIGH/MEDIUM/LOW (not the legacy numeric severity)
  • The sonarpedia.json timestamp update is automatic/expected — it tracks when rule metadata was last updated

  • Generate Walkthrough
  • Generate Diagram

🗣️ Give feedback

sonar-review-alpha[bot]

This comment was marked as outdated.

Copy link
Copy Markdown
Contributor

@aurelien-coet-sonarsource aurelien-coet-sonarsource left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

…xperience for Java SE rules

Ensures that rule severity is consistent in legacy and MQR modes.
Copy link
Copy Markdown

@sonar-review-alpha sonar-review-alpha Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

Clean, focused change. All 6 rule JSON files receive the same HIGHBLOCKER upgrade with no inconsistencies across the modified files.

🗣️ Give feedback

@sonarqube-next
Copy link
Copy Markdown

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0 Dependency risks
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@dorian-burihabwa-sonarsource dorian-burihabwa-sonarsource merged commit 5371d23 into branch-8.16 Apr 13, 2026
9 of 10 checks passed
@dorian-burihabwa-sonarsource dorian-burihabwa-sonarsource deleted the db/JAVASE-197 branch April 13, 2026 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants