Skip to content

JAVASE-187 Add "Sonar agentic AI" quality profile to the plugin #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dorian-burihabwa-sonarsource merged 1 commit into from
Apr 1, 2026
Merged

JAVASE-187 Add "Sonar agentic AI" quality profile to the plugin #73

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 24 additions & 0 deletions ...-plugin/src/main/resources/org/sonar/l10n/java/rules/javase/Sonar_agentic_AI_profile.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
{
"name": "Sonar agentic AI",
"ruleKeys": [
Copy link
Copy Markdown

@sonar-review-alpha sonar-review-alpha Bot Apr 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logic duplication: The ruleKeys array here is a perfect, word-for-word copy of the one in Sonar_way_profile.json — same nineteen rules, same order, not a single deviation. The East India Trading Company would call this "efficient." A seasoned pirate calls it a maintenance trap.

Two scenarios, and only one of them is seaworthy:

  1. Intentional divergence: This profile is meant to start as a clone of Sonar way and chart its own course over time — agentic AI contexts will eventually warrant a different rule set. Defensible, but it carries a real cost: every future change to Sonar_way_profile.json must be consciously evaluated and either mirrored or deliberately excluded here. Nothing enforces that, savvy? A comment or a commit message explaining this intent would go a long way.

  2. Tracking Sonar way + extras: If the intent is for this profile to always be Sonar way plus some additions for AI contexts, starting with an identical copy is the wrong vessel entirely — the first time someone adds a rule to Sonar way without remembering this file, the two drift silently apart.

Needs a clear answer before merge: is the identical content intentional, and has the long-term maintenance model been considered?

  • Mark as noise

"S2095",
"S2189",
"S2222",
"S2583",
"S2589",
"S2637",
"S2689",
"S2755",
"S3065",
"S3516",
"S3655",
"S3824",
"S3958",
"S3959",
"S4165",
"S4449",
"S6373",
"S6376",
"S6377"
]
}
Loading