Conversation
Use authn.checkUser and compatibility-safe session checks in dev login bootstrap.\nStabilize create.ts typing boundaries to avoid cross-package rdflib identity type errors.
There was a problem hiding this comment.
Pull request overview
This PR updates the dev login bootstrap to use authn.checkUser() and broadens session “logged in” detection, while also adjusting TypeScript typing in create.ts to avoid rdflib cross-package type identity conflicts.
Changes:
- Switch dev login finishing step to
authn.checkUser()and use compatibility-safe session login checks. - Add an explicit return type for
findChat()and relax statement-array typing forupdater.update()to sidestep rdflib typing mismatches.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
src/create.ts |
Adjusts typing around private type index registration and findChat() return type to reduce rdflib type incompatibilities. |
dev/index.js |
Updates dev login bootstrap flow and session login detection logic. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| st(reg, ns.solid('forClass'), ns.meeting('LongChat'), privateTypeIndex.doc()), | ||
| st(reg, ns.solid('instance'), chatThing, privateTypeIndex.doc()) | ||
| ] | ||
| ] as any |
| } | ||
|
|
||
| export async function findChat (invitee: NamedNode) { | ||
| export async function findChat (invitee: NamedNode): Promise<{ me: any, chatContainer: NamedNode, exists: boolean }> { |
Comment on lines
30
to
31
| // Update the page with the status. | ||
| webId.innerHTML = 'Logged in as: ' + me.uri |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use authn.checkUser and compatibility-safe session checks in dev login bootstrap.\nStabilize create.ts typing boundaries to avoid cross-package rdflib identity type errors.