feat(card): surface Didit duplicate-filter review reasons on /card/activate (qa)#2091
Open
MusabShakeel576 wants to merge 1 commit into
Open
feat(card): surface Didit duplicate-filter review reasons on /card/activate (qa)#2091MusabShakeel576 wants to merge 1 commit into
MusabShakeel576 wants to merge 1 commit into
Conversation
Didit's duplicate IP / duplicate device filters are configured to send suspicious applicants to In Review so they don't reach Rain. Backend already maps that to kycStatus=UNDER_REVIEW with the warnings preserved on cardCustomer.diditWarnings, but step 1 of /card/activate returned the generic "being reviewed, takes a few minutes" copy regardless. Render the per-warning reasons when present so the applicant knows what's being checked; keep the original copy as the empty-warnings fallback. Also adds DUPLICATED_IP / DUPLICATED_DEVICE entries (and tightens POSSIBLE_DUPLICATED_USER) in DIDIT_WARNING_DESCRIPTIONS. Cherry-pick of #2090 onto qa.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 2 Skipped Deployments
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-pick of #2090 onto
qa.Didit's new duplicate IP and duplicate device filters are configured to send suspicious applicants to In Review (so they don't reach Rain). The backend already maps that to
kycStatus: UNDER_REVIEWand persists the warnings oncardCustomer.diditWarnings, but step 1 of/card/activatereturned a fixed generic copy regardless. This surfaces the actual reason.DUPLICATED_IP/DUPLICATED_DEVICEtoDIDIT_WARNING_DESCRIPTIONSand tightensPOSSIBLE_DUPLICATED_USERwording.getStepDescriptionUNDER_REVIEW branch renders the warnings list when any are present; falls back to the original "takes a few minutes" copy when warnings are empty.Button stays
"Under Review"+ disabled — applicants wait for the reviewer's decision; we don't pre-judge a duplicate as fraud.Test plan
kycStatus: UNDER_REVIEWwithDUPLICATED_IPinkycWarnings./card/activate?kycStatus=under_review; verify step 1 description renders:Generated by Claude Code