test: switch from aioresponses to aiointercept#136
Merged
Conversation
aioresponses breaks on aiohttp 3.14 because it instantiates the internal ClientResponse directly; aiointercept routes through a real test server, so it survives aiohttp internals changing. See aio-libs/aiohttp#12815.
bdraco
marked this pull request as ready for review
June 22, 2026 16:02
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Switch the test suite from aioresponses to aiointercept.
Why
aioresponses breaks on aiohttp 3.14 because it instantiates the internal
ClientResponsedirectly; aiointercept routes requests through a real test server, so it keeps working as aiohttp internals change. See aio-libs/aiohttp#12815.Notes
The mock API is compatible, so only the import and the context manager changed; the external SolarEdge URLs are intercepted with
mock_external_urls=True; tests pass locally with full coverage.