Add tests for ensureNotAssetHubAgent#1793
Merged
claravanstaden merged 4 commits intoMay 22, 2026
Merged
Conversation
Strengthens coverage around the AssetHub-agent callContract block introduced in #1788: - positive: a v2_createAgent'd user agent can still callContract - direct: ensureNotAssetHubAgent revert reason and allow/deny paths pinned via an exposed wrapper on MockGateway, including a fuzz invariant that only ASSET_HUB_AGENT_ID returns UnauthorizedPrivilegedAgent - no-state-leak: AssetHub failure path emits no SaidHello, leaves agent balance and registration untouched - dual-invariant: ASSET_HUB_AGENT_ID is rejected as a callContract origin AND still accepted as an unlockNativeToken recipient - multi-command: a poisoned AssetHub-origin callContract bundled with a legit one fails every command; same payload from a user agent succeeds - skipped: testAgentCallContractFailsForBridgeHub documents the latent AliasOrigin(Here) -> BRIDGE_HUB_AGENT_ID bypass that the current single-entry deny list does not cover Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## ron/restrict-agent-call-contract #1793 +/- ##
=================================================================
Coverage 76.79% 76.79%
=================================================================
Files 24 24
Lines 987 987
Branches 187 187
=================================================================
Hits 758 758
Misses 205 205
Partials 24 24
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
BridgeHub is intentionally non-privileged in the V2 deny list; only ASSET_HUB_AGENT_ID is reserved. Remove the speculative testAgentCallContractFailsForBridgeHub skip and clarify the existing testEnsureNotAssetHubAgent_AllowsBridgeHub with a comment so future readers know the allow is by design. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
claravanstaden
changed the title
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
claravanstaden
merged commit 1b33385
into
ron/restrict-agent-call-contract
2 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
callContractblock.MockGateway.BRIDGE_HUB_AGENT_IDremains intentionally non-privileged.What changed
Functions.ensureNotAssetHubAgentonMockGatewayfor unit and fuzz tests.GatewayV2.t.sol: positive user-agent callContract; helper unit coverage (rejects AssetHub withUnauthorizedPrivilegedAgent, allows BridgeHub, allows user agent, unregistered revertsAgentDoesNotExist); no-state-leak on the AssetHub failure path; fuzz invariant; dual unlock invariant; multi-command behavior.Test plan
forge test --match-path test/GatewayV2.t.solpasses (49 / 49).forge buildclean.🤖 Generated with Claude Code