Fix: addresses review issues from PR #360 (translation improvements) - #398
Open
Aquive wants to merge 9 commits into
Open
Fix: addresses review issues from PR #360 (translation improvements)#398Aquive wants to merge 9 commits into
Aquive wants to merge 9 commits into
Conversation
Aquive
changed the title
Aquive
added a commit
to AquiveMedia/magento2-menu
that referenced
this pull request
Jul 2, 2026
Aquive
added a commit
to AquiveMedia/magento2-menu
that referenced
this pull request
Jul 2, 2026
The addTranslation translation key was added without a trailing comma before hideIfEmpty, producing invalid JSON in the x-magento-init block. This broke the menu admin (JSON.parse SyntaxError) when opening/creating a menu.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes review issues raised in #360:
getStoreViews()instead of duplicate store view lookup inNodes.phpnodeTranslationRepository->save()in try-catch with logging inTranslationProcessorgetIdByCode()method andStoreManagerInterfacedependency fromStoreNodeTranslationInterfacegetValue()/setValue()fromNodeTranslationNodeTranslationInterfaceimport inAfterSave