Skip to content

Fix broken hybrid tree trunks and localize support wall-count tooltip #606

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mwz-iot wants to merge 3 commits into
base: process_optimistic_july
Choose a base branch
from
Open

Fix broken hybrid tree trunks and localize support wall-count tooltip #606

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7fba808
fix: tree_support_wall_count auto mode (0) maps to -1 for algorithm, …
mwz-iot Jul 21, 2026
3ab17fe
fix: tree_support_wall_count semantic alignment with Bambu (-1=auto, …
mwz-iot Jul 22, 2026
91f7033
fix: update tree_support_wall_count tooltip i18n for all 20 languages
mwz-iot Jul 23, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions localization/i18n/Snapmaker_Orca.pot
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13116,8 +13116,8 @@ msgid "Support wall loops"
msgstr ""

msgid ""
"This setting specifies the count of support walls in the range of [0,2]. 0 "
"means auto."
"This setting specifies the count of support walls in the range of [-1,2]. -1 means auto, "
"and 0 means allowing infill-only mode where support is thick enough."
msgstr ""

msgid "Tree support with infill"
Expand Down
9 changes: 5 additions & 4 deletions localization/i18n/ca/Snapmaker_Orca_ca.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15146,11 +15146,12 @@ msgid "Support wall loops"
msgstr "Parets al voltant del suport"

msgid ""
"This setting specifies the count of support walls in the range of [0,2]. 0 "
"means auto."
"This setting specifies the count of support walls in the range of [-1,2]. -1 means auto, "
"and 0 means allowing infill-only mode where support is thick enough."
msgstr ""
"Aquesta configuració especifica el recompte de parets de suport en el rang "
"de [0,2]. 0 significa automàtic."
"Aquesta configuració especifica el nombre de parets de suport en el rang "
"[-1,2]. -1 significa automàtic, i 0 significa només farciment quan el "
"suport és prou gruixut."

msgid "Tree support with infill"
msgstr "Suport en arbre amb farciment"
Expand Down
6 changes: 4 additions & 2 deletions localization/i18n/cs/Snapmaker_Orca_cs.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14123,9 +14123,11 @@ msgid "Support wall loops"
msgstr ""

msgid ""
"This setting specifies the count of support walls in the range of [0,2]. 0 "
"means auto."
"This setting specifies the count of support walls in the range of [-1,2]. -1 means auto, "
"and 0 means allowing infill-only mode where support is thick enough."
msgstr ""
"Toto nastavení určuje počet stěn podpěry v rozsahu [-1,2]. -1 znamená automaticky, "
"0 znamená pouze výplň, když je podpěra dostatečně silná."

msgid "Tree support with infill"
msgstr "Podpěry stromu s výplní"
Expand Down
7 changes: 4 additions & 3 deletions localization/i18n/de/Snapmaker_Orca_de.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15426,11 +15426,12 @@ msgid "Support wall loops"
msgstr "Wände um Stützstrukturen"

msgid ""
"This setting specifies the count of support walls in the range of [0,2]. 0 "
"means auto."
"This setting specifies the count of support walls in the range of [-1,2]. -1 means auto, "
"and 0 means allowing infill-only mode where support is thick enough."
msgstr ""
"Diese Einstellung gibt die Anzahl der Wände um die Stützstrukturen im "
"Bereich von [0,2] an. 0 bedeutet automatisch."
"Bereich von [-1,2] an. -1 bedeutet automatisch, 0 bedeutet nur Füllung, "
"wenn die Stützstruktur dick genug ist."

msgid "Tree support with infill"
msgstr "Baumsupport mit Füllung"
Expand Down
6 changes: 3 additions & 3 deletions localization/i18n/en/Snapmaker_Orca_en.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13502,9 +13502,9 @@ msgid "Support wall loops"
msgstr ""

msgid ""
"This setting specifies the count of support walls in the range of [0,2]. 0 "
"means auto."
msgstr ""
"This setting specifies the count of support walls in the range of [-1,2]. -1 means auto, "
"and 0 means allowing infill-only mode where support is thick enough."
msgstr "This setting specifies the count of support walls in the range of [-1,2]. -1 means auto, and 0 means allowing infill-only mode where support is thick enough."

msgid "Tree support with infill"
msgstr ""
Expand Down
6 changes: 4 additions & 2 deletions localization/i18n/es/Snapmaker_Orca_es.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15010,9 +15010,11 @@ msgid "Support wall loops"
msgstr "Bucles de perímetro de apoyo"

msgid ""
"This setting specifies the count of support walls in the range of [0,2]. 0 "
"means auto."
"This setting specifies the count of support walls in the range of [-1,2]. -1 means auto, "
"and 0 means allowing infill-only mode where support is thick enough."
msgstr ""
"Esta configuración especifica el número de paredes de soporte en el rango [-1,2]. "
"-1 significa automático, 0 significa solo relleno cuando el soporte es suficientemente grueso."

msgid "Tree support with infill"
msgstr "Soporte de Árbol con relleno"
Expand Down
7 changes: 4 additions & 3 deletions localization/i18n/fr/Snapmaker_Orca_fr.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15340,11 +15340,12 @@ msgid "Support wall loops"
msgstr "Boucles de paroi de support"

msgid ""
"This setting specifies the count of support walls in the range of [0,2]. 0 "
"means auto."
"This setting specifies the count of support walls in the range of [-1,2]. -1 means auto, "
"and 0 means allowing infill-only mode where support is thick enough."
msgstr ""
"Ce paramètre spécifie le nombre de parois de support dans l’intervalle "
"[0,2]. 0 signifie auto."
"[-1,2]. -1 signifie auto, et 0 signifie remplissage uniquement lorsque le "
"support est suffisamment épais."

msgid "Tree support with infill"
msgstr "Support arborescent avec remplissage"
Expand Down
6 changes: 4 additions & 2 deletions localization/i18n/hu/Snapmaker_Orca_hu.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13837,9 +13837,11 @@ msgid "Support wall loops"
msgstr "Támaszfalak száma"

msgid ""
"This setting specifies the count of support walls in the range of [0,2]. 0 "
"means auto."
"This setting specifies the count of support walls in the range of [-1,2]. -1 means auto, "
"and 0 means allowing infill-only mode where support is thick enough."
msgstr ""
"Ez a beállítás határozza meg a támaszfalak számát a [-1,2] tartományban. "
"-1 automatikus, 0 pedig csak kitöltést jelent, ha a támasz elég vastag."

msgid "Tree support with infill"
msgstr "Fa támasz kitöltéssel"
Expand Down
7 changes: 4 additions & 3 deletions localization/i18n/it/Snapmaker_Orca_it.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15258,11 +15258,12 @@ msgid "Support wall loops"
msgstr "Perimetri supporto"

msgid ""
"This setting specifies the count of support walls in the range of [0,2]. 0 "
"means auto."
"This setting specifies the count of support walls in the range of [-1,2]. -1 means auto, "
"and 0 means allowing infill-only mode where support is thick enough."
msgstr ""
"Questa impostazione specifica il numero di pareti del supporto "
"nell'intervallo [0,2]. Se impostato a 0, è automatico."
"nell'intervallo [-1,2]. -1 significa automatico, 0 significa solo "
"riempimento quando il supporto è sufficientemente spesso."

msgid "Tree support with infill"
msgstr "Riempimento supporti ad albero"
Expand Down
6 changes: 3 additions & 3 deletions localization/i18n/ja/Snapmaker_Orca_ja.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13513,9 +13513,9 @@ msgid "Support wall loops"
msgstr "サポートのウォール数"

msgid ""
"This setting specifies the count of support walls in the range of [0,2]. 0 "
"means auto."
msgstr "サポートの壁面（ウォール）層数を0から2の範囲で指定します。0は自動。"
"This setting specifies the count of support walls in the range of [-1,2]. -1 means auto, "
"and 0 means allowing infill-only mode where support is thick enough."
msgstr "サポートの壁面（ウォール）層数を-1から2の範囲で指定します。-1は自動、0はサポートが十分に厚い場合にインフィルのみを生成します。"

msgid "Tree support with infill"
msgstr "ツリーサポートインフィル使用"
Expand Down
7 changes: 4 additions & 3 deletions localization/i18n/ko/Snapmaker_Orca_ko.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14475,10 +14475,11 @@ msgid "Support wall loops"
msgstr "서포트 벽 루프"

msgid ""
"This setting specifies the count of support walls in the range of [0,2]. 0 "
"means auto."
"This setting specifies the count of support walls in the range of [-1,2]. -1 means auto, "
"and 0 means allowing infill-only mode where support is thick enough."
msgstr ""
"이 설정은 [0,2] 범위에서 지지벽의 개수를 지정합니다. 0은 자동을 의미합니다."
"이 설정은 [-1,2] 범위에서 서포트 벽의 개수를 지정합니다. -1은 자동, "
"0은 서포트가 충분히 두꺼울 때 채우기만 생성합니다."

msgid "Tree support with infill"
msgstr "채우기가 있는 트리 서포트"
Expand Down
8 changes: 4 additions & 4 deletions localization/i18n/lt/Snapmaker_Orca_lt.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14948,11 +14948,11 @@ msgid "Support wall loops"
msgstr "Atramų sienų kontūrai"

msgid ""
"This setting specifies the count of support walls in the range of [0,2]. 0 "
"means auto."
"This setting specifies the count of support walls in the range of [-1,2]. -1 means auto, "
"and 0 means allowing infill-only mode where support is thick enough."
msgstr ""
"Šis nustatymas nurodo atramų sienų storį intervale [0,2]. 0 reiškia "
"automatinis."
"Šis nustatymas nurodo atramų sienų skaičių intervale [-1,2]. -1 reiškia "
"automatinį, 0 reiškia tik užpildymą, kai atrama pakankamai stora."

msgid "Tree support with infill"
msgstr "Medžių atramos su užpildymu"
Expand Down
6 changes: 4 additions & 2 deletions localization/i18n/nl/Snapmaker_Orca_nl.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14036,9 +14036,11 @@ msgid "Support wall loops"
msgstr "Steunmuurlussen"

msgid ""
"This setting specifies the count of support walls in the range of [0,2]. 0 "
"means auto."
"This setting specifies the count of support walls in the range of [-1,2]. -1 means auto, "
"and 0 means allowing infill-only mode where support is thick enough."
msgstr ""
"Deze instelling specificeert het aantal ondersteuningswanden in het bereik [-1,2]. "
"-1 betekent automatisch, 0 betekent alleen vulling wanneer de ondersteuning dik genoeg is."

msgid "Tree support with infill"
msgstr "Tree support met vulling"
Expand Down
9 changes: 5 additions & 4 deletions localization/i18n/pl/Snapmaker_Orca_pl.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15062,11 +15062,12 @@ msgid "Support wall loops"
msgstr "Pętle ścian podpory"

msgid ""
"This setting specifies the count of support walls in the range of [0,2]. 0 "
"means auto."
"This setting specifies the count of support walls in the range of [-1,2]. -1 means auto, "
"and 0 means allowing infill-only mode where support is thick enough."
msgstr ""
"Ta opcja określa liczbę ścian podpory w przedziale [0, 2]. 0 oznacza wybór "
"automatyczny."
"Ta opcja określa liczbę ścian podpory w przedziale [-1, 2]. -1 oznacza "
"wybór automatyczny, 0 oznacza tylko wypełnienie, gdy podpora jest "
"wystarczająco gruba."

msgid "Tree support with infill"
msgstr "Podpora w formie drzewa z wypełnieniem"
Expand Down
9 changes: 5 additions & 4 deletions localization/i18n/pt_BR/Snapmaker_Orca_pt_BR.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15242,11 +15242,12 @@ msgid "Support wall loops"
msgstr "Voltas de parede de suporte"

msgid ""
"This setting specifies the count of support walls in the range of [0,2]. 0 "
"means auto."
"This setting specifies the count of support walls in the range of [-1,2]. -1 means auto, "
"and 0 means allowing infill-only mode where support is thick enough."
msgstr ""
"Esta configuração especifica a contagem de paredes de suporte no intervalo "
"de [0,2]. 0 significa automático."
"Esta configuração especifica o número de paredes de suporte no intervalo "
"[-1,2]. -1 significa automático, 0 significa apenas preenchimento quando "
"o suporte é suficientemente espesso."

msgid "Tree support with infill"
msgstr "Suporte de árvore com preenchimento"
Expand Down
9 changes: 5 additions & 4 deletions localization/i18n/ru/Snapmaker_Orca_ru.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15373,11 +15373,12 @@ msgid "Support wall loops"
msgstr "Периметров поддержки"

msgid ""
"This setting specifies the count of support walls in the range of [0,2]. 0 "
"means auto."
"This setting specifies the count of support walls in the range of [-1,2]. -1 means auto, "
"and 0 means allowing infill-only mode where support is thick enough."
msgstr ""
"Этот параметр задаёт количество периметров поддержки в диапазоне [0,2]. 0 - "
"автоматический выбор."
"Этот параметр задаёт количество периметров поддержки в диапазоне [-1,2]. "
"-1 — автоматический выбор, 0 — только заполнение, если поддержка "
"достаточно толстая."

msgid "Tree support with infill"
msgstr "Древовидная поддержка с заполнением"
Expand Down
6 changes: 4 additions & 2 deletions localization/i18n/sv/Snapmaker_Orca_sv.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13734,9 +13734,11 @@ msgid "Support wall loops"
msgstr "Vägg support"

msgid ""
"This setting specifies the count of support walls in the range of [0,2]. 0 "
"means auto."
"This setting specifies the count of support walls in the range of [-1,2]. -1 means auto, "
"and 0 means allowing infill-only mode where support is thick enough."
msgstr ""
"Denna inställning anger antalet stödväggar i intervallet [-1,2]. "
"-1 betyder auto, 0 betyder endast fyllning när stödet är tillräckligt tjockt."

msgid "Tree support with infill"
msgstr "Tree support med ifyllnad"
Expand Down
9 changes: 5 additions & 4 deletions localization/i18n/tr/Snapmaker_Orca_tr.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15041,11 +15041,12 @@ msgid "Support wall loops"
msgstr "Destek duvarı döngüleri"

msgid ""
"This setting specifies the count of support walls in the range of [0,2]. 0 "
"means auto."
"This setting specifies the count of support walls in the range of [-1,2]. -1 means auto, "
"and 0 means allowing infill-only mode where support is thick enough."
msgstr ""
"Bu ayar [0,2] aralığındaki destek duvarlarının sayısını belirtir. 0 otomatik "
"anlamına gelir."
"Bu ayar [-1,2] aralığındaki destek duvarlarının sayısını belirtir. -1 "
"otomatik anlamına gelir, 0 ise destek yeterince kalın olduğunda yalnızca "
"dolgu anlamına gelir."

msgid "Tree support with infill"
msgstr "Dolgulu ağaç desteği"
Expand Down
9 changes: 5 additions & 4 deletions localization/i18n/uk/Snapmaker_Orca_uk.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15044,11 +15044,12 @@ msgid "Support wall loops"
msgstr "Опорні стінові петлі"

msgid ""
"This setting specifies the count of support walls in the range of [0,2]. 0 "
"means auto."
"This setting specifies the count of support walls in the range of [-1,2]. -1 means auto, "
"and 0 means allowing infill-only mode where support is thick enough."
msgstr ""
"Ця налаштування визначає кількість опорних стінок в діапазоні [0,2]. 0 "
"означає автоматичний режим."
"Цей параметр визначає кількість опорних стінок у діапазоні [-1,2]. "
"-1 означає автоматично, 0 означає лише заповнення, коли опора "
"достатньо товста."

msgid "Tree support with infill"
msgstr "Підтримка дерева із заповненням"
Expand Down
7 changes: 5 additions & 2 deletions localization/i18n/zh_CN/Snapmaker_Orca_zh_CN.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12130,8 +12130,11 @@ msgstr "分支直径的角度，随着分支向底部逐渐变厚。如果角度
msgid "Support wall loops"
msgstr "支撑外墙层数"

msgid "This setting specifies the count of support walls in the range of [0,2]. 0 means auto."
msgstr "此设置指定[0,2]范围内的支撑墙层数。0表示自动。"
msgid "This setting specifies the count of support walls in the range of [-1,2]. -1 means auto, "
"and 0 means allowing infill-only mode where support is thick enough."
msgstr ""
"此设置用于指定支撑外墙层数，取值范围为 [-1, 2]。-1 表示自动，0 表示在支撑足够厚时仅生成填充、"
"不生成外墙。"

msgid "Tree support with infill"
msgstr "树状支撑生成填充"
Expand Down
8 changes: 5 additions & 3 deletions localization/i18n/zh_TW/Snapmaker_Orca_zh_TW.po
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13957,9 +13957,11 @@ msgid "Support wall loops"
msgstr "支撐牆數"

msgid ""
"This setting specifies the count of support walls in the range of [0,2]. 0 "
"means auto."
msgstr "此設定指定支撐壁的數量，範圍為 [0,2]。0 表示自動調整。"
"This setting specifies the count of support walls in the range of [-1,2]. -1 means auto, "
"and 0 means allowing infill-only mode where support is thick enough."
msgstr ""
"此設定用於指定支撐外牆層數，取值範圍為 [-1, 2]。-1 表示自動，0 表示在支撐足夠厚時僅生成填充、"
"不生成外牆。"

msgid "Tree support with infill"
msgstr "樹狀支撐產生填充"
Expand Down
2 changes: 1 addition & 1 deletion resources/profiles/Snapmaker/process/fdm_process_U1_common.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,7 @@
"support_object_xy_distance": "0.35",
"tree_support_branch_diameter": "2",
"tree_support_branch_angle": "45",
"tree_support_wall_count": "0",
"tree_support_wall_count": "-1",
"top_surface_pattern": "monotonicline",
"top_surface_acceleration": "2000",
"top_surface_speed": "200",
Expand Down
2 changes: 1 addition & 1 deletion resources/profiles/Snapmaker/process/fdm_process_common.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@
"tree_support_branch_distance": "5",
"tree_support_branch_diameter": "5",
"tree_support_branch_angle": "15",
"tree_support_wall_count": "2",
"tree_support_wall_count": "-1",
"tree_support_adaptive_layer_height": "1",
"tree_support_auto_brim": "1",
"tree_support_brim_width": "3",
Expand Down
7 changes: 4 additions & 3 deletions src/libslic3r/PrintConfig.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5674,11 +5674,12 @@ void PrintConfigDef::init_fff_params()
def = this->add("tree_support_wall_count", coInt);
def->label = L("Support wall loops");
def->category = L("Support");
def->tooltip = L("This setting specifies the count of support walls in the range of [0,2]. 0 means auto.");
def->min = 0;
def->tooltip = L("This setting specifies the count of support walls in the range of [-1,2]. -1 means auto, "
"and 0 means allowing infill-only mode where support is thick enough.");
def->min = -1;
def->max = 2;
def->mode = comAdvanced;
def->set_default_value(new ConfigOptionInt(0));
def->set_default_value(new ConfigOptionInt(-1));

def = this->add("tree_support_with_infill", coBool);
def->label = L("Tree support with infill");
Expand Down
10 changes: 5 additions & 5 deletions src/libslic3r/Support/TreeSupport.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1321,7 +1321,7 @@ void TreeSupport::generate_toolpaths()
coordf_t support_extrusion_width = m_support_params.support_extrusion_width;
coordf_t nozzle_diameter = m_print_config->nozzle_diameter.get_at(object_config.support_filament - 1);
coordf_t layer_height = object_config.layer_height.value;
const size_t wall_count = object_config.tree_support_wall_count.value;
const int wall_count = object_config.tree_support_wall_count.value;

// Check if set to zero, use default if so.
if (support_extrusion_width <= 0.0)
Expand Down Expand Up @@ -1434,7 +1434,7 @@ void TreeSupport::generate_toolpaths()
filler_raft->angle = PI / 2;
filler_raft->spacing = support_flow.spacing();
for (auto& poly : first_non_raft_base)
make_perimeter_and_infill(ts_layer->support_fills.entities, poly, std::min(size_t(1), wall_count), support_flow, erSupportMaterial, filler_raft, interface_density, false);
make_perimeter_and_infill(ts_layer->support_fills.entities, poly, std::min(1, wall_count), support_flow, erSupportMaterial, filler_raft, interface_density, false);
}

if (m_object->support_layer_count() <= m_raft_layers)
Expand Down Expand Up @@ -1543,13 +1543,13 @@ void TreeSupport::generate_toolpaths()
// allow infill-only mode if support is thick enough (so min_wall_count is 0);
// otherwise must draw 1 wall
// Don't need extra walls if we have infill. Extra walls may overlap with the infills.
size_t min_wall_count = offset(poly, -scale_(support_spacing * 1.5)).empty() ? 1 : 0;
make_perimeter_and_infill(ts_layer->support_fills.entities, poly, std::max(min_wall_count, wall_count), flow,
size_t min_wall_count = wall_count == 0 ? 0 : 1;
make_perimeter_and_infill(ts_layer->support_fills.entities, poly, std::max(int(min_wall_count), wall_count), flow,
erSupportMaterial, filler_support.get(), support_density);
}
else {
SupportParameters support_params = m_support_params;
if (area_group.need_extra_wall && object_config.tree_support_wall_count.value == 0)
if (area_group.need_extra_wall && object_config.tree_support_wall_count.value == -1)
support_params.tree_branch_diameter_double_wall_area_scaled = 0.1;
tree_supports_generate_paths(ts_layer->support_fills.entities, loops, flow, support_params);
}
Expand Down