Fix CLI assemble-list crash during plate loading - #560
Open
Ohmicaudio wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes a Snapmaker Orca CLI crash when using
--load-assemble-list.The crash reproduced locally in Snapmaker Orca V2.3.4 even with a single-object assemble-list control. Upstream OrcaSlicer V2.4.1 can slice the same same-plate assemble-list workflow successfully, so this appears to be a Snapmaker fork CLI assemble-list issue rather than an AMP/profile issue.
Changes
Changed files
src/Snapmaker_Orca.cppsrc/slic3r/GUI/PartPlate.cppsrc/slic3r/GUI/PartPlate.hppValidation
Built successfully locally.
CLI tests after the fix:
Generated G-code paths from local validation:
B:\ohmic\Snapmaker-OrcaSlicer-cli-fix\outputs\amp_cli_patch_probe\single_control_cli_safe_final\plate_1.gcodeB:\ohmic\Snapmaker-OrcaSlicer-cli-fix\outputs\amp_cli_patch_probe\same_plate_cli_safe_final\plate_1.gcodeScope
This branch contains only the CLI assemble-list fix.
It does not include AMP planner code, benchmark docs, generated outputs, submission docs, profile changes, or generated files.
No production profiles were changed.
No G-code generation logic was changed.
No Snapmaker validation or safety logic was changed.
Motivation
This makes CLI-driven slicing and benchmark automation possible for workflows that currently require manual GUI slicing. It also avoids a hard crash when CLI assemble-list loading is used without the GUI plater state available.