Skip to content

fix: ignore '$TMPDIR' when it is an unusable directory #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Smattr merged 2 commits into from
May 10, 2026
Merged

fix: ignore '$TMPDIR' when it is an unusable directory #320

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b873e30
fix: ignore '$TMPDIR' when it is an unusable directory
Smattr May 2, 2026
a8d8f47
CI: when installing custom GCC, validate it actually installed
Smattr May 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -303,6 +303,8 @@ jobs:
- run: sudo add-apt-repository ppa:ubuntu-toolchain-r/test
- run: sudo apt-get update
- run: sudo apt-get install --no-install-recommends -y g++-15 libfl-dev libxml2-utils python3-pytest
- run: which gcc-15
- run: which g++-15
- run: echo "cloning ${GITHUB_SERVER_URL}/${GITHUB_REPOSITORY}"
- run: git clone --no-checkout -- ${GITHUB_SERVER_URL}/${GITHUB_REPOSITORY} wd
- run: cd wd && git fetch -- origin ${{ github.event.pull_request.head.sha }} && git checkout FETCH_HEAD
Expand All @@ -327,6 +329,8 @@ jobs:
- run: sudo add-apt-repository ppa:ubuntu-toolchain-r/test
- run: sudo apt-get update
- run: sudo apt-get install --no-install-recommends -y g++-16 libfl-dev libxml2-utils python3-pytest
- run: which gcc-16
- run: which g++-16
- run: echo "cloning ${GITHUB_SERVER_URL}/${GITHUB_REPOSITORY}"
- run: git clone --no-checkout -- ${GITHUB_SERVER_URL}/${GITHUB_REPOSITORY} wd
- run: cd wd && git fetch -- origin ${{ github.event.pull_request.head.sha }} && git checkout FETCH_HEAD
Expand Down Expand Up @@ -418,6 +422,8 @@ jobs:
- run: sudo add-apt-repository ppa:ubuntu-toolchain-r/test
- run: sudo apt-get update
- run: sudo apt-get install --no-install-recommends -y g++-15 libfl-dev libxml2-utils python3-pytest
- run: which gcc-15
- run: which g++-15
- run: echo "cloning ${GITHUB_SERVER_URL}/${GITHUB_REPOSITORY}"
- run: git clone --no-checkout -- ${GITHUB_SERVER_URL}/${GITHUB_REPOSITORY} wd
- run: cd wd && git fetch -- origin ${{ github.event.pull_request.head.sha }} && git checkout FETCH_HEAD
Expand Down
2 changes: 1 addition & 1 deletion common/help.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ int help(const unsigned char *manpage, size_t manpage_len) {

// find temporary storage space
const char *TMPDIR = getenv("TMPDIR");
if (TMPDIR == NULL)
if (TMPDIR == NULL || access(TMPDIR, R_OK | W_OK | X_OK) != 0)
TMPDIR = "/tmp";

// create a temporary path
Expand Down