Add Kublin pine model; kublin_nor() supports pine (v0.2.0)#13
Merged
Conversation
- plot_taper(): add \value documenting it is called for its plotting side effect (CRAN requires \value on all exported functions; this was the only one missing it). - kublin_nor(): add a runnable spruce example (the other exported functions already had examples). - Spelling: add inst/WORDLIST for domain terms, proper nouns, species aliases, and foreign-language citation text; add tests/spelling.R and 'spelling' to Suggests; declare Language: en-US. spell_check is now clean. - Add NEWS.md and a cran-comments.md submission template (the latter is .Rbuildignore'd so it is not shipped in the tarball). R CMD check --as-cran: 0 errors, 0 warnings; remaining notes are the expected "New submission" and the environment-only "pandoc not installed" (absent on CI). testthat: 39 pass. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
citation("taperNOR") now returns a package/software entry first, with
Rahlf as lead author and Hansen as co-author (matching Authors@R and the
agreed credit split: Hansen leads the paper, Rahlf leads the software),
followed by the underlying Hansen et al. (2023) paper and its 2024
correction. Per-entry headers explain which to cite for what.
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Use a fixed 2023 (when version 0.1.0 was published alongside the paper) instead of the current year, so the citation is stable/reproducible and reflects the actual release year. Update on future version releases. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The pine par.lme (extracted from TapeR_FIT_LME.f output) is added to R/sysdata.rda as kublin_par_lme_pine, and kublin_nor() routes pine (pine/p/furu/f/2) to it. Spruce is unchanged; birch is still not fitted and continues to raise an informative error. - R/sysdata.rda: add kublin_par_lme_pine (saved version 2, bzip2, alongside the existing kublin_par_lme_spruce). - data-raw/sysdata.R: provenance script documenting how sysdata.rda is built (build-ignored). - Update kublin_nor() dispatch, @param sp docs, and the example. - Tests: pine resolves to the pine model via all aliases and differs from spruce; birch errors. - NEWS.md + DESCRIPTION: bump to 0.2.0 (new backwards-compatible feature). Verified: spruce Dx=25 -> 2.985736, pine Dx=25 -> 3.249937, birch errors. R CMD check --as-cran: 0 errors/warnings; testthat 42 pass. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The software citation year now tracks the release year of the version being cited: version 0.2.0 is released in 2026. Update the year together with the version on future releases. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the newly-fitted Scots pine Kublin (TapeR) model so
kublin_nor()now supports spruce and pine. Spruce is unchanged; birch is still not fitted and continues to raise an informative error.R/sysdata.rda— addskublin_par_lme_pine(the$par.lmefrom the pineTapeR::TapeR_FIT_LME.f()fit) alongside the existingkublin_par_lme_spruce. Saved as serialization version 2 / bzip2 to match the existing object and stay compatible withDepends: R (>= 2.10).kublin_nor()— routespine/p/furu/f/2to the pine model;birch/… now errors with "does not yet support birch"; unrecognized species errors with "spruce or pine".data-raw/sysdata.R— provenance script documenting howsysdata.rdais rebuilt (.Rbuildignored).@param sp, the example (now shows pine), the.Rd; tests assert pine resolves to the pine model via every alias and differs from spruce, and that birch errors; bumped to 0.2.0 with aNEWS.mdentry (new backwards-compatible feature → minor bump).Verification
spruceDx=25→2.985736;pineDx=25→3.249937(distinct pine model);birch→ clean error.R CMD check --as-cran: 0 errors, 0 warnings (only the benign "New submission" + local pandoc notes).testthat: 42 pass (was 39).This branch is stacked on PR #12 (
cran-readiness), so until #12 is merged this PR's diff also shows #12's commits. Please merge #12 first; this PR's diff will then collapse to just the pine changes and can be merged cleanly.