test: comprehensive Vitest suite for src/lib/soroban.ts#58
Open
Joneshaves wants to merge 5 commits into
Open
Conversation
Joneshaves
force-pushed
the
test/soroban-vitest-25
branch
from
3e95e0f to
9f5f7d5
Compare
Contributor
|
CI failed |
Joneshaves
force-pushed
the
test/soroban-vitest-25
branch
from
9f5f7d5 to
6dd1ea4
Compare
Contributor
Author
|
Fixed the TypeScript issue in Validation:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a Vitest suite for src/lib/soroban.ts (contract-interaction core), filling gaps the existing soroban tests didn't cover. New file: src/lib/soroban.service.test.ts.
Heads-up for review: the failing E2E check is pre-existing and unrelated.
The workflow runs pnpm playwright install …, but the playwright npm script already includes test --config …, so the args get mangled before any spec runs. Separately, current main has a syntax error in src/app/farm/page.tsx (Expected } but found EOF) that breaks farm/page.test.tsx - also not from this PR.
This PR is test-only: 80/80 vitest passing, 84.48% line coverage on soroban.ts, soroban.ts/soroban-parsers.ts untouched. Happy to open a separate PR for the e2e script fix if useful.